On (09/05/16 10:07), Jakub Hrozek wrote:
>On Wed, May 04, 2016 at 11:36:57PM +0200, Lukas Slebodnik wrote:
>> On (27/04/16 10:51), Jakub Hrozek wrote:
>> >the attached patches implement unit tests for the pam_sss module using
>> >pam_wrapper and libpamtest. In my testing, the coverage is around 75%
>> >with mostly the parts that require running as root being untested.
>> >I worked on this patchset even though the features for 1.14 are in full
>> >swing because there are several tickets that will require us to patch
>> >pam_sss, so it's important to have the code that changes tested. In
>> >addition, when we merge Dan's patches to use TLS with integration
>> >then we'll be able to also test authentication in integration tests
>> >easily using libpamtest-python.
>> >However, our CI fails for me constantly:
>> > http://sssd-ci.duckdns.org/logs/job/42/75/fedora_rawhide/ci.html
>> >The strange thing is that running CI locally works fine and so does make
>> >check. Can anyone help point me in the right direction as to what should
>> >I check next? I suspect some of the environment variables might not be
>> >set correctly, but I don't see why..
>> Are you sure it pass locally with valgrind?
>> It failed because there are valgrind errors.
>> I can see then on fedora 22 and fedora 23
>> I cannot see them on fedora 24 or fedora rawhide
>> but it fails as well
>> If the problem is with missing environment variables
>> then you might log all environment variables in main function
>just a quick update: the issues in tests were resolved. I hit two bugs
>so once Andreas approves them, I will build a new pam_wrapper RPM for
>Fedora and EPEL so that we can formally review the pam_sss test patches.
But now the tests fail, so I did something wrong, somewhere. I don't
think I will have time to look into this until next week, sorry.