On Tue, Jul 01, 2014 at 01:41:29PM +0200, Lukas Slebodnik wrote:
On (01/07/14 13:33), Sumit Bose wrote:
On Tue, Jul 01, 2014 at 12:23:45PM +0200, Lukas Slebodnik wrote:
ehlo,
ad_gpo_test is linked with library NDR_NBT, which is part of samba4. Simple patch is attached.
ACK. Sorry I really forgot about checking Makefiles and spec-files when doing the review.
I was testing patches as well, but I didn't noticed all small problems.
LS
BTW I saw in Noam's nfs patches he is using $(NULL) after the end of lists in Makefile.am. I saw it also in other projects. Do we want to use this patter as well?
FreeIPA is using this as well. I find it useful but do not have a strong opinion one way or the other.
There are two positive responses. I will wait little bit more and if there aren't any other objections. I will send new path.
Sorry, too late: 99f8be128274eba264ea1434a7eb2800bced5902
I thought you were asking in general or for future patches, not for this one...