From 8bb98b9ec53b901987fe40547bb9e2bcdce8e1cf Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Wed, 24 May 2017 21:24:20 +0200 Subject: [PATCH 1/2] IPA: Avoid using uninitialized ret value when skipping entries from the joined domain --- src/providers/ipa/ipa_s2n_exop.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/providers/ipa/ipa_s2n_exop.c b/src/providers/ipa/ipa_s2n_exop.c index 15904e019..3f5f98595 100644 --- a/src/providers/ipa/ipa_s2n_exop.c +++ b/src/providers/ipa/ipa_s2n_exop.c @@ -991,6 +991,7 @@ static errno_t s2n_response_to_attrs(TALLOC_CTX *mem_ctx, } else { DEBUG(SSSDBG_TRACE_ALL, "[%s] from root domain, skipping.\n", fq_name); + ret = EOK; /* Free resources and continue in the loop */ } ber_memfree(domain_name); ber_memfree(name); From 23d8a8fd5f8933d40c185d896f3d4b15bb2a3d16 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Wed, 24 May 2017 21:26:22 +0200 Subject: [PATCH 2/2] IPA: Return from function after marking a request as finished --- src/providers/ipa/ipa_s2n_exop.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/providers/ipa/ipa_s2n_exop.c b/src/providers/ipa/ipa_s2n_exop.c index 3f5f98595..39ed17cbf 100644 --- a/src/providers/ipa/ipa_s2n_exop.c +++ b/src/providers/ipa/ipa_s2n_exop.c @@ -2664,6 +2664,7 @@ static void ipa_s2n_get_list_done(struct tevent_req *subreq) } else { tevent_req_error(req, EINVAL); } + return; } ret = sysdb_attrs_get_string(state->attrs->sysdb_attrs, SYSDB_SID_STR,