[SSSD] Re: [PATCH] Make sdap_process_group_send() static

[Petr Cech]

On 05/09/2016 10:01 AM, Petr Cech wrote:
>  On 05/09/2016 09:54 AM, Jakub Hrozek wrote:
> > Hi,
> >
> > a trivial code-hygiene patch is attached.
> >
> >
> > 0001-Make-sdap_process_group_send-static.patch
> >
> >
> > From ac33446aaa78b65c6891f486e9ad462101f88a79 Mon Sep 17 00:00:00 2001
> > From: Jakub Hrozek <jhrozek(a)redhat.com&gt;
> > Date: Tue, 8 Dec 2015 21:10:27 +0100
> > Subject: [PATCH] Make sdap_process_group_send() static
> >
> > ---
> >  src/providers/ldap/sdap_async_groups.c | 17 +++++++++--------
> >  1 file changed, 9 insertions(+), 8 deletions(-)
> >
> > diff --git a/src/providers/ldap/sdap_async_groups.c
> > b/src/providers/ldap/sdap_async_groups.c
> > index
> > 3ccf7deb53d365a106cd18af1835f527424d5bf3..f4633a69c7dcd2bf29778408d9e3b88bef99f6ab
> > 100644
> > --- a/src/providers/ldap/sdap_async_groups.c
> > +++ b/src/providers/ldap/sdap_async_groups.c
> > @@ -1197,14 +1197,15 @@ static errno_t
> > sdap_process_group_create_dns(TALLOC_CTX *mem_ctx,
> >      return EOK;
> >  }
> >
> > -struct tevent_req *sdap_process_group_send(TALLOC_CTX *memctx,
> > -                                           struct tevent_context *ev,
> > -                                           struct sss_domain_info *dom,
> > -                                           struct sysdb_ctx *sysdb,
> > -                                           struct sdap_options *opts,
> > -                                           struct sdap_handle *sh,
> > -                                           struct sysdb_attrs *group,
> > -                                           bool enumeration)
> > +static struct tevent_req *
> > +sdap_process_group_send(TALLOC_CTX *memctx,
> > +                        struct tevent_context *ev,
> > +                        struct sss_domain_info *dom,
> > +                        struct sysdb_ctx *sysdb,
> > +                        struct sdap_options *opts,
> > +                        struct sdap_handle *sh,
> > +                        struct sysdb_attrs *group,
> > +                        bool enumeration)
> >  {
> >      struct ldb_message_element *el;
> >      struct ldb_message_element *ghostel;
> > -- 2.4.11
>
>  Hi Jakub,
>
>  LGTM and I am waiting for CI.
>
>  Regards 
CI:
http://sssd-ci.duckdns.org/logs/job/43/01/summary.html

ACK

Regards

-- 
Petr^4 Čech