Title: #334: Print a warning when enumeration is requested but disabled
I basically agree with @lslebodn here. 'SSSDBG_CONF_SETTINGS' seems the
appropriate debug level to use.
Also, a review about the commit short-log and the commit message:
- commit short-log:
We have a template (https://github.com/SSSD/sssd/blob/master/.git-commit-template
explains how the commit should look like. Based on that, I'd suggest something like:
"CONFDB: Warn that `getent passwd` doesn't return all users by design"
- commit message:
"Add an explanatory message to be logged once, at the start-up, mentioning that in
case enumeration is not enabled, `getent passwd` won't return all users by design.
The debug level chosen to show the message is `SSSDBG_CONF_SETTINGS`."
About the patch itself:
+ DEBUG(SSSDBG_OP_FAILURE, "Please note With No enumeration sssd "
+ "getent passwd does not return all users by design, see man "
+ "pages for more information\n");
Please, do not mix words started with uppercase letters in the middle of the sentence.
I'd rewrite the text as something like: "Please, note that when `enumeration` is
disabled `getent passwd` does not return all users by design. See `sssd.conf` man page for
more detailed information".
See the full comment at https://github.com/SSSD/sssd/pull/334#issuecomment-318357905