Re: [SSSD] [PATCH] nss: group enumeration fix

[Lukas Slebodnik]

On (24/10/14 12:20), Sumit Bose wrote:
> Hi,
>
> this patch fixes an issue Lukas found while doing regression testing with
> the new view/override code.
>
> bye,
> Sumit
> From 1dc1db1672b55d14d2f654d108bfe63e4ba30a8d Mon Sep 17 00:00:00 2001
> From: Sumit Bose 
> Date: Fri, 24 Oct 2014 11:28:54 +0200
> Subject: [PATCH] nss: group enumeration fix
>
> The view/override patches introduced and issue with group enumeration
> where all groups are returned with the same name. This patch should fix
> it.
> Fixes: https://fedorahosted.org/sssd/ticket/2475

Patch fixed the problem.
I have just a little coding style question.
> src/responder/nss/nsssrv_cmd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/responder/nss/nsssrv_cmd.c b/src/responder/nss/nsssrv_cmd.c
> index 4ec99c1..278e6d3 100644
> --- a/src/responder/nss/nsssrv_cmd.c
> +++ b/src/responder/nss/nsssrv_cmd.c
> @@ -2677,6 +2677,8 @@ static int fill_grent(struct sss_packet *packet,
>                 /* Override names are not fully qualified */
>                 add_domain = true;
>             }
>    } else {
>        orig_name = NULL;

I do not prefer lot of if/else statements.
Could we assign NULL to orig_name before if statement?
                                  or in the beggining of for loop.

It would be good to add comment to prevent removing line in future.

LS