On Fri, Dec 03, 2010 at 08:19:08AM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/03/2010 05:19 AM, Sumit Bose wrote:
> On Thu, Dec 02, 2010 at 09:19:02AM -0500, Stephen Gallagher wrote:
> On 11/29/2010 09:15 AM, Sumit Bose wrote:
>>>> Hi,
>>>>
>>>> this patch adds a ldap_chpass_uri config option as requested in trac
>>>> ticket #680. The first patch just removes an unused struct member.
>>>>
>>>> bye,
>>>> Sumit
>>>>
>
> Patch 0001: Ack.
>
> Patch 0002: Nack. It doesn't apply atop current master. Is there a
> dependent patch I should be aware of?
>
>> I would expect that you need to apply this patch on top of 'Add new
>> account expired rule to LDAP access provider'
Right, I wasn't thinking. It applies fine atop those patches.
Nack (minor).
With
https://fedorahosted.org/sssd/ticket/653 in mind, we probably need
to get in the habit of adding new options to the sssd.api.d files.
The two new options where already sssd-ldap.conf, I just moved them from
the /auth to the /chpass section. We agreed on irc that they should not
be exposed via the SSSDConfig API for the IPA provider, because that are
not evaluated here.
+ dns_service_name = dp_opt_get_string(ctx->opts->basic,
+ SDAP_CHPASS_DNS_SERVICE_NAME);
+ if (!dns_service_name) {
+ DEBUG(7, ("Service name for chpass discovery set to %s\n",
+ dns_service_name));
+ }
I think you meant to print this when dns_service_name != NULL.
done (it's hard to break patterns :-)
Thanks for the review, new version attached.
bye,
Sumit
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkz47kwACgkQeiVVYja6o6MSJQCgkPjuaa+x7t4C6GAS52eiu/vc
U9UAn2SN9o9N1Bp0PKdrTgKxSOCM3d+p
=Rdbd
-----END PGP SIGNATURE-----
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel