Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf

[Jakub Hrozek]

On Tue, Apr 09, 2013 at 11:50:35AM -0500, Ariel Barria wrote:
> > Hi Ariel,
> >
> > you don't have to duplicate the case statements in a switch statement if
> > both should yield the same result. Instead of:
> >    case EPERM:
> >        DEBUG(SSSDBG_CRIT_FAILURE,
> >             ("Not enough permission to read configuration file.\n"));
> >        break;
> >    case EACCES:
> >        DEBUG(SSSDBG_CRIT_FAILURE,
> >             ("Not enough permission to read configuration file.\n"));
> >        break;
> >
> > You can use:
> >    case EPERM:
> >    case EACCES:
> >        DEBUG(SSSDBG_CRIT_FAILURE,
> >             ("Not enough permission to read configuration file.\n"));
> >        break;
>
> Ok, thank you
> > Also instead of "Not enough permission" I would rather say
> > "Insufficient permissions".
>
> I am hopeful ^_^
> > Almost there :)
>
> new patch

Ack!