On 11/15/2012 5:45 AM, Stephen Gallagher wrote:
This is obviously already a significant enhancement, and of course the difference will be more pronounced for much larger environments. I'm prepared to give this an ack, with one comment to whoever pushes the patch upstream: please reflow the changes in nsssrv_cmd.c's fill_grent() that are now exceeding the 80-character line limit due to the new indentation.
Hmm, I see a few other lines in that file that exceed 80 characters; are there scenarios where there is an exception to that limit or were those just not caught ;)?
It looks like there were only two lines in my diff for that file that exceeded 80 characters, the attached updated patch should fix that.
Thanks for the ack. Will this just go into head or will it be pushed back to the 1.9 branch? I've got an open RHEL support ticket requesting this be back ported to RHEL 6, given they're supposed to be shipping 1.9 in RHEL 6.4, it might be easier to get them to include it if it becomes part of the 1.9 branch :). Or if whoever commits this "accidentally" slips it into the RHEL 6 repo while they're twiddling bits ;)...