On 12/14/2015 11:39 AM, Pavel Březina wrote:
>On 12/14/2015 10:43 AM, Jakub Hrozek wrote:
>>On Mon, Dec 07, 2015 at 11:46:38AM +0100, Pavel Březina wrote:
>>>On 12/04/2015 03:51 PM, Jakub Hrozek wrote:
>>>>On Thu, Dec 03, 2015 at 12:45:55PM +0100, Pavel Březina wrote:
>>>>>On 12/03/2015 11:48 AM, Jakub Hrozek wrote:
>>>>>>On Wed, Dec 02, 2015 at 11:58:55AM +0100, Pavel Březina wrote:
>>>>>>>This solves situation where you want to use those globals on
>>>>>>>other place
>>>>>>>than in *_common.c.
>>>>>>>
>>>>>>>I also created
https://fedorahosted.org/sssd/ticket/2890 so
we
>>>>>>>can avoid
>>>>>>>order-dependency on header files such as sysdb_services.h
which I
>>>>>>>had to fix
>>>>>>>for AD patch.
>>>>>>
>>>>>>Looks like tests failed:
>>>>>>
>>>>>>http://sssd-ci.duckdns.org/logs/job/34/17/fedora20/ci-build-debug/ci-make-tests.log
>>>>>>
>>>>>
>>>>>I forgot to run tests... new patches are attached.
>>>>>
>>>>
>>>>Thanks, the patches now build. I have two questions:
>>>> 1) Since we're moving code around anymore, would it make sense
to
>>>> also move the enums with option indexes to opts.h? I find it a bit
>>>> odd they are in common.h
>>>
>>>Yes, this would be nice.
>>
>>after an IRC discussion this turned out to be a bit more work than
>>expected, so we can postpone until later..
>>
>>However, please also change krb5_opts.h in the same way..
>
>
>Attached.
I accidentally did not include the first patch, I'm sending it again, five
patches now.