On Fri, Oct 24, 2014 at 08:45:21PM +0200, Lukas Slebodnik wrote:
Please note I don't like the warning either, I just prefer to only upstram code that will be readable even in future when we look for some unrelated bug in that area..
Ok. I prepared the patch based on Jakub's suggestion (with kind approval of Lukas) to speed up the resolution on this issue.
Michal
From 66f65a3462daef32d9d75974809ddb6de1c940e0 Mon Sep 17 00:00:00 2001 From: Michal Zidek mzidek@redhat.com Date: Thu, 23 Oct 2014 10:55:08 +0200 Subject: [PATCH] MONITOR: Fix warning may be used uninitialized MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
This warning is caused be change 579e5d4b7a3ca161ea7518b2996905fa22c15995 "MONITOR: Allow confdb to be accessed by nonroot user"
src/monitor/monitor.c: In function ‘main’: src/monitor/monitor.c:2953:24: error: ‘monitor’ may be used uninitialized in this function [-Werror=maybe-uninitialized] monitor->is_daemon = !opt_interactive; ^ cc1: all warnings being treated as errors
src/monitor/monitor.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/monitor/monitor.c b/src/monitor/monitor.c index 0dea327..b55757d 100644 --- a/src/monitor/monitor.c +++ b/src/monitor/monitor.c @@ -1723,7 +1723,9 @@ static errno_t load_configuration(TALLOC_CTX *mem_ctx, * when SSSD runs as nonroot */ ret = chown(cdb_file, ctx->uid, ctx->gid); if (ret != 0) {
ret = errno;
/* Init ret to suppress gcc warning with high -O level */ret = EINVAL;if (errno) ret = errno; DEBUG(SSSDBG_FATAL_FAILURE, "chown failed for [%s]: [%d][%s].\n", cdb_file, ret, sss_strerror(ret));warning is fixed.
I'm fine with this version. I let final ACK to jakub :-)
LS
Ack from me as well. Let's not delay a resolution of a simple warning any longer.
Thank you both for the discussion.