On Mon, May 06, 2013 at 10:05:41PM +0200, Jakub Hrozek wrote:
> On Mon, May 06, 2013 at 06:14:56PM +0200, Sumit Bose wrote:
> > Hi,
> > this patch reads the flat name and the SID from AD and stores then to
> > the cache. It fixes https://fedorahosted.org/sssd/ticket/1468
> > and the flat name is needed e.g. for
> > https://fedorahosted.org/sssd/ticket/1648
and the SID e.g. for
> > https://fedorahosted.org/sssd/ticket/1558
> > bye,
> > Sumit
> mostly looks good to me and seems to work fine. I just have a couple of
> suggestions and a question:
> I think the AD subdomains provider should be present in the configAPI,
> mostly for completeness' sake.
> Now that we can match the domain and subdomain in the re_expression in
> the AD provider, too think we should document the fact.
> See attached mini-patche for these two suggestions, feel free to squash
> them in if you agree.
> And one question -- do you think it would make sense to default to the
> part of ad_domain until the first dot if the discovery fails? I would
> rather not use the special option I posted earlier but maybe some kind
> of fallback would be nice.
Btw I also opened a RFE for realmd to start naming the SSSD domains with
the full name to be able to match both flat and full name:
sssd-devel mailing list