URL:
https://github.com/SSSD/sssd/pull/241
Title: #241: FleetCommander Integration
pbrezina commented:
"""
I just briefly read the code, haven't tried it.
```c
@@ -126,10 +126,9 @@ static void choose_target(struct data_provider *provider,
name = "PAM Chpass 2nd";
break;
case SSS_PAM_OPEN_SESSION:
- target = DP_TARGET_SENTINEL;
- method = DP_METHOD_SENTINEL;
+ target = DPT_SESSION;
+ method = DPM_SESSION_HANDLER;
name = "PAM Open Session";
- pd->pam_status = PAM_SUCCESS;
break;
...
/* Check that target is configured. */
if (target != DP_TARGET_SENTINEL
&& !dp_target_enabled(provider, NULL, target)) {
target = DP_TARGET_SENTINEL;
method = DP_METHOD_SENTINEL;
pd->pam_status = PAM_MODULE_UNKNOWN;
}
```
What happens here if session provider is not set? With this patch we return
`PAM_MODULE_UNKNOWN` but it was `PAM_SUCCESS` before. Doesn't this cause any kind of
problem?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/241#issuecomment-323305584