On Tue, Aug 16, 2011 at 02:35:42PM +0200, Pavel Březina wrote:
sss_debuglevel - change the debug level on the fly
Requires "New DEBUG facility" patches.
+ struct debuglevel_tool_ctx *tool_ctx, int debug_to_set,
+ const char *config_file
+ int ret;
+ int err;
+ const char *values;
+ char **section = NULL;
+ TALLOC_CTX *ctx = talloc_new(NULL);
Please name temporary context tmp_ctx so it is immediatelly clear that it
is a just a temporary one.
My only other comment is that I don't really like the style of the function
definitions, but that's just a subjective thing.
I would appreciate a review from somebody else as I saw and commented on
the patche before they went to the list (and it was the last to be done
this way, time to take the training wheels off :-))