Re: [SSSD] [PATCH] Move and extend function for finding principal in keytab

[Jan Zelený]

Jan Zelený  wrote:
> Stephen Gallagher  wrote:
> > On 03/29/2011 03:50 AM, Jan Zelený wrote:
> > > Jan Zelený  wrote:
> > > > Jan Zelený  wrote:
> > > > > This functionality will be required in tickets #781 and #700.
> > > > >
> > > > > Jan
> > > >
> > > > This is corrected version - removes some compilation-time error
> > > > messages.
> > > >
> > > > Jan
> > >
> > > Another correction: the code mixup has been eliminated.
> >
> > Nack.
> >
> > In match_principal(), use
> > krb5_unparse_name_flags(ctx, principal,
> >                     KRB5_PRINCIPAL_UNPARSE_NO_REALM,
> >                     &primary);
> >
> > Please use krb5_principal_get_realm() instead of krb5_princ_realm(). The
> > latter is deprecated. This will also make your comparisons later
> > somewhat easier, as krb5_principal_get_realm() returns a string instead
> > of krb5_data.
>
> Fixed patch in attachment.
>
> Jan

Just a reminder that the updated patch needs review.

Thanks
Jan