Re: [SSSD] [PATCHES] PAM: authenticate agains cache

[Pavel Reichl]

On 06/24/2015 10:55 AM, Jakub Hrozek wrote:
> On Tue, Jun 23, 2015 at 10:55:41AM +0200, Pavel Reichl wrote:
> > On 06/23/2015 10:34 AM, Jakub Hrozek wrote:
> > > On Fri, Jun 05, 2015 at 07:01:30PM +0200, Pavel Reichl wrote:
> > > > On 05/20/2015 05:16 PM, Pavel Reichl wrote:
> > > > > Hello,
> > > > >
> > > > > please see first version of these patches. I'm currently working on unit
> > > > > test for the second patch which will be part of the second revision of the
> > > > > patch set.
> > > > >
> > > > > Thanks!
> > > > >
> > > > > sssd-devel mailing list
> > > > > [e-mail]
> > > > > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> > > >
> > > > Jakub asked me off list to move resetting of
> > > > SYSDB_LAST_ONLINE_AUTH_WITH_CURRENT_TOKEN attribute from ldap code to pam
> > > > code. Please see updated patch set.
> > > >
> > > > Thanks!
> > >
> > > Can you rebase the patches, please? I'll take a look at them..
> > > _______________________________________________
> > > sssd-devel mailing list
> > > [e-mail]
> > > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> >
> > Sure. Rebased patches attached.
>
> Hi,
>
> We should extend the PAM responder unit test together with these
> patches so that the new functionality is covered.

Hello,  I think I addressed all your concerns except this one. Feel free 
to continue reviewing updated patches or delay reviewing untill I add 
the unit test.

Thanks!

[snip]