On (21/05/13 17:32), Jakub Hrozek wrote:
>On Tue, May 21, 2013 at 05:17:14PM +0200, Lukas Slebodnik wrote:
>> ehlo,
>>
>> This patch changes dependencies among libsss_util and libsss_child,
>> libsss_crypt, libsss_debug. Library libsss_util no longer depends on
>> any internal library. Each program, which was linked with libsss_util,
>> now directly link necessary libraries
>> (libsss_child, libsss_crypt, libsss_debug)
>>
>>
https://fedorahosted.org/sssd/ticket/1928
>>
>> Patch attached.
>> Adding Timo to CC
>>
>> LS
>
>It might improve readability to create a variable that would expand to
>libsss_util.la, libsss_child.la and libsss_debug.la. Then the following:
>
>> @@ -622,7 +619,10 @@ sssd_LDADD = \
>> $(SSSD_LIBS) \
>> $(LIBNL_LIBS) \
>> $(KEYUTILS_LIBS) \
>> - libsss_util.la
>> + libsss_util.la \
>> + libsss_crypt.la \
>> + libsss_child.la \
>> + libsss_debug.la
>>
>
>Would become:
>
> $(SSSD_LIBS) \
> $(LIBNL_LIBS) \
> $(KEYUTILS_LIBS) \
> - libsss_util.la
> + (SSSD_PRIVATE_LIBS)
I only replaced libsss_util.la with variable SSSD_INTERNAL_LTLIBS.
libsss_util.la is not required everywhere, therefore it was removed or replaced
with other internal library (for example libsss_debug.la)
New patch attached.
LS
Hi,
the changes look good to me, but the patch doesn't apply on the current
master after pushing some other patches. Could you please rebase?