On 12/02/2014 12:50 PM, Lukas Slebodnik wrote:
On (29/10/14 17:17), Pavel Reichl wrote:
Hello,
please see attached patch.
This patch is part of solution for https://fedorahosted.org/sssd/ticket/1991 which aims to unify return values of sysdb calls in case no results are found.
a) this patch cannot be applied on current master. b) I wrote similar patch becuse sssd_be crashed in function get_object_from_cache. sysdb_search_object_by_sid didn' returned ENOENT and res->msgs was NULL (result: dereference of NULL pointer) -- it is yet another result of broken IPA <-> AD trust c) Could you compare your version and mine? Feel free to include my patch to yours if it is not good enogh.
d) test test_sysdb_delete_by_sid seems to be unrelated to this patch. I would prefer to have it in separete patch.
LS
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Please send you patch in new thread and then I'll rebase my patches on top of it. Please also fix commit message.
Thanks!