On Fri, Oct 10, 2014 at 02:09:03PM +0200, Pavel Reichl wrote:
On 10/06/2014 11:20 AM, Pavel Reichl wrote:
>
>On 01/30/2014 11:35 AM, Denis Kutin wrote:
>>Dear friends,
>>
>>Using sssd, for a long time, I have come across with a problem recently,
>>which I would like to solve with your help.
>>
>>I provide centralized authentication and authorization service for a
>>huge heterogeneous network. And in my case it would be "nice and easy"
>>if sssd used only shells(5). I believe this mechanism is sufficient for
>>identification of an allowed shell.
>>
>>I take a liberty to offer you this tiny patch, which will let use
>>wildcard (*) in param allowed_shells in sssd.conf
>>
>>What do you think about it?
>>
>>--
>>Denis Kutin
>>
>>
>>_______________________________________________
>>sssd-devel mailing list
>>sssd-devel(a)lists.fedorahosted.org
>>https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>Hello Denis,
>
>You patch seems to generally solve the problem. But there are some minor
>nitpicks with it:
>* it needs rebasing (update debug message format)
>* move check out of loop
>* do not make lines longer then 80 chars
>* probably document your use case would be helpful
>
>Are you willing to do the changes?
>If you are too busy I can do the changes myself. You would still keep the
>authorship of the patch. I would be just named in Signed-off-by tag. Would
>that work for you?
>
>Thanks again for the patch!
>
>
>_______________________________________________
>sssd-devel mailing list
>sssd-devel(a)lists.fedorahosted.org
>https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Hello,
I took the liberty and prepared the patch.
Thanks.
Looks good to me, just specified a wrong ticket in the commit message. I
can fix that before pushing.
Otherwise ACK.