On 05/26/2015 03:09 PM, Jakub Hrozek wrote:
On Tue, May 26, 2015 at 11:13:38AM +0200, Jakub Hrozek wrote:
> I'll test the patch now..
Functionality passed:
[jhrozek@client] sssd $ [(review)] su - jhrozek
Password: (I used the IPA admin password here)
[jhrozek@client] ~ $ [] klist
Ticket cache: KEYRING:persistent:1000:krb_ccache_tovv73R
Default principal: admin(a)LINUX.TEST
Valid starting Expires Service principal
05/26/2015 15:07:31 05/27/2015 15:07:31 krbtgt/LINUX.TEST(a)LINUX.TEST
So fix the nitpicks and I'll ack :-)
Great, thanks.
Please see attached patch. I'm completely sure that I've absolutely
sorted out the nitpicks...unless I've made them even worse. :-)
I think that the coverity warning was false positive, because the map
value would never be read when uninitialized, but to get rid of the
warning I added a check and call the function conditionally. Would you
prefer If I rather initialized the variable?
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel