On Tue, Aug 30, 2016 at 01:16:05PM +0200, Pavel Březina wrote:
On 08/04/2016 06:02 PM, Jakub Hrozek wrote:
> Hi,
>
> to reproduce the netgroups failure:
> * getent netgroup testngr # to verify the netgroup is there
> * sss_cache -E
> * pkill -USR1 sssd # make sssd go offline
> * getent netgroup testngr
>
> to reproduce the autofs maps failure:
> * automount -m # to verify the maps are there
> * pkill -USR1 sssd # make sssd go offline
> * automount -m # to verify the maps are there
>
> Before the patches, neither offline lookup would return the expected
> results. Both lookups should return results with the patches.
> + /* Try to fall back to cache */
> + ret = lookup_netgr_step(step_ctx);
> + if (ret == EOK) {
> + /* We have cached results to return */
> + nss_setent_notify_done(dctx->netgr);
> + }
Aren't you missing return here?
Of course I am, sorry. See new patches, there is also a test (but the
test requires Justin's pending patches to be reliable..)