Simo Sorce wrote:
On Wed, 2009-09-16 at 14:33 -0400, Stephen Gallagher wrote:
Dmitri, it's a very simple change that will be very easy to resolve with 'git rebase' and 'git mergetool'.
There's no reason that a complete fix should be held back for the convenience of any one developer.
Also, no. The upstream SSSD repository is one-way. To remove it, we would have to apply a negative diff and commit that. We're not going to remove a solid fix because it might inconvenience you.
Steve, it doesn't make sense to revert now, but in general I agree with Dmitri that it is at least polite to wait and have a say from the main maintainer of the code before pushing a patch. Unless it is blocking other developers or is urgent for any other reasonable motive.
Simo.
Thank you Simo for support. A rare occasion when we are in agreement! The main point is (thought it will make my merge more complex, I can deal with it using merge tools as you said), but this or similar change has to be done in 5-6 other places so rather than push a separate patch that addresses just one problem it should be addressed by fixing a corresponding ticket. https://fedorahosted.org/sssd/ticket/161. This all could have been discussed before the push and best approach could have been sorted out.
I will send the patches later today if I have time...