On Wed, Jun 29, 2016 at 12:05:42PM +0200, Lukas Slebodnik wrote:
On (29/06/16 11:54), Pavel Březina wrote:
On 06/28/2016 06:24 PM, Jakub Hrozek wrote:
Hi,
here is my branch that implements using the fully qualified names in sysdb for users and groups: https://github.com/jhrozek/sssd/commits/sysdb-fqdn
The SSSD code changes are done. There are some downstream tests that are failing (some sudo and some HBAC tests), but I think I can chase those down quickly.
But -- I still don't have the upgrade code written and I only tested the IPA overrides and IPA-AD trust code manually, so there might be a lot of bugs there. It is also a lot of stuff to review.
With that in mind, I would like to ask other developers for opinions -- should we still pursue pushing this refactoring into 1.14? Or should we release 1.14.0 first and push this patchset as the first thing into 1.15?
Well there are few places where we told ourselves that it will be fixed as a side effect of those patches. Given the scale I'm fine with postponing it to 1.15 but than we need to fix those.
However, it still may be better to do it for 1.14 if doable.
+1 for 1.14 if possible
I would prefer this as well. My first tests didn't went too bad. Besides other things I tested Smartcard and 2-factor authentication which both worked as expected.
I added 3 fixes to my copy at https://fedorapeople.org/cgit/sbose/public_git/sssd.git/log/?h=jhrozek_sysdb...
This first is needed if there is no home-directory defined in AD. The other 2 I came across while checking if lookups by UPN with alternative suffix are working. The lookups were working but the output changed depending on the lookup history. The functionality from the patches is not present in current master as well so chances are that there might similar issues here.
About cache updates. I think this is the critical part in the decision here. If updates are not working or are too complex we cannot commit the refactoring.
Maybe we should save a copy of the old cache to allow downgrades without loosing the cache content if something goes wrong with the update?
Maybe we can move the update code to sssctl and call it like 'sssctl update_cache old_file new_file' from SSSD. If the tool reports an error SSSD might start with an empty cache instead and the copy of the old cache can be used to update the cache later manually or with a fixed version of sssctl. Maybe it would be even possible to call the tool during the upgrade of the rpm package and abort the rpm transaction if the cache cannot be updated? Even if this won't work the careful/worried admin can install the latest version of SSSD with the update tool to a new system and use it to check if the tool can update existing caches by copying them and running the tool on them.
bye, Sumit