7:24 a.m.
On Tue, 2012-12-04 at 11:18 +0100, Pavel Březina wrote:
On 12/04/2012 12:10 AM, Simo Sorce wrote:
> Sorry for the previous non-building rebase, my fault, it was just a rebase
> silently working but generating errors as the underlying code was slightly
> changed.
>
> Additional fixes for patch 3 as per PAvel comment.
> Couldn;t move the enum definition because it is use by pam_sss.c too and that's
> in the client which can;t include authtok.c
>
> Builds, but haven;t re-tested due to time constraints.
>
> Simo.
>
> Simo Sorce (4):
> Code can only check for cached passwords
> Add function to safely wipe memory.
> Add authtok utility functions.
> Change pam data auth tokens.
>
> Makefile.am | 4 +
> src/db/sysdb.h | 3 +-
> src/db/sysdb_ops.c | 13 +--
> src/providers/data_provider.h | 9 +-
> src/providers/dp_auth_util.c | 76 +++++---
> src/providers/dp_pam_data_util.c | 113 ++++++------
> src/providers/ipa/ipa_auth.c | 6 +-
> src/providers/krb5/krb5_auth.c | 55 +++---
> src/providers/krb5/krb5_child.c | 148 ++++++++-------
> src/providers/krb5/krb5_child_handler.c | 59 +++++-
> .../krb5/krb5_delayed_online_authentication.c | 50 ++++--
> src/providers/krb5/krb5_renew_tgt.c | 18 +--
> src/providers/ldap/ldap_auth.c | 90 ++++------
> src/providers/ldap/sdap_async.c | 4 +-
> src/providers/ldap/sdap_async.h | 7 +-
> src/providers/ldap/sdap_async_connection.c | 88 +++++----
> src/providers/proxy/proxy.h | 7 +-
> src/providers/proxy/proxy_auth.c | 14 +-
> src/providers/proxy/proxy_child.c | 51 +++--
> src/responder/pam/pam_LOCAL_domain.c | 52 ++----
> src/responder/pam/pamsrv_cmd.c | 159 +++++++++-------
> src/tests/krb5_child-test.c | 13 +-
> src/tests/sysdb-tests.c | 6 +-
> src/util/authtok.c | 194 ++++++++++++++++++++
> src/util/authtok.h | 180 ++++++++++++++++++
> src/util/util.c | 9 +
> src/util/util.h | 9 +
> 27 files changed, 950 insertions(+), 487 deletions(-)
> create mode 100644 src/util/authtok.c
> create mode 100644 src/util/authtok.h
>
> _______________________________________________
> sssd-devel mailing list
> sssd-devel(a)lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>
Warnings during compilation...
src/util/authtok.c: In function 'sss_authtok_set':
src/util/authtok.c:164:1: error: control reaches end of non-void
function [-Werror=return-type]
src/util/authtok.c: In function 'sss_authtok_get_ccfile':
src/util/authtok.c:75:1: error: control reaches end of non-void function
[-Werror=return-type]
src/util/authtok.c: In function 'sss_authtok_get_password':
src/util/authtok.c:58:1: error: control reaches end of non-void function
[-Werror=return-type]
src/util/authtok.c: In function 'sss_authtok_get_size':
src/util/authtok.c:36:1: error: control reaches end of non-void function
[-Werror=return-type]
cc1: all warnings being treated as errors
This is odd, it didn't complain here ... seem like here the compiler did
not realize that all possible enum cases are intercepted in the
switch/case statements I changed to avoid the 'default' and does not see
they all return ... oh well I'll add an additional return to silence it.
Simo.
--
Simo Sorce * Red Hat, Inc * New York