URL:
https://github.com/SSSD/sssd/pull/237
Title: #237: providers: Move hostid from ipa to sdap
jhrozek commented:
"""
Hi,
I'm sorry the review takes so long. We're swamped with fixing bugs at the moment
and the Easter holidays didn't help either.
I think since the patch moves quite a bit of code to the generic layer, it could be a bit
generic as well. The current approach that moves all the IPA code to LDAP provider has a
side-effect of exposing pieces of interface that are only (to the best of my knowledge)
available only in IPA to the LDAP provider. For example I'm not sure if any other LDAP
schema exposes something like UUID or memberof for hosts.
So what do you think about not exposing the part that fetches the host groups outside the
IPA provider? The `sdap_host_info_send/recv` request would only return the host. Then, in
the IPA provider, there would be a `ipa_host_info_send/recv` request that would first call
sdap_host_info and then proceed to fetch the hostgroups as well. This could also mean that
the only host-related options that would be publicly exposed in the LDAP documentation
would be the host class, name and the public key objectclass.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/237#issuecomment-295856665