Re: [SSSD] [PATCH] Excluding attributes from map

[Stephen Gallagher]

On Wed, 2011-06-29 at 15:56 +0200, Jan Zelený wrote:
>  This patch add the possibility to exclude attributes when building
> requested 
>  attribute list from a map. It also utilizes this new functionality by not 
>  loading memberuid of parent groups during initgroups in rfc2307 schema. 

Nack.
../src/providers/ldap/sdap_async_accounts.c: In function
'sdap_initgr_rfc2307_send':
../src/providers/ldap/sdap_async_accounts.c:2320:32: error: to be safe
all intermediate pointers in cast from 'char **' to 'const char **' must
be 'const' qualified [-Werror=cast-qual]


Also, please use strcasecmp() in attr_is_filtered(), since there's no
guarantee of the case we get back from LDAP.

The general concept of the patch is good.