On 10/08/2015 10:32 AM, Lukas Slebodnik wrote:
On (07/10/15 20:51), Nikolai Kondrashov wrote:
> On 09/30/2015 06:15 PM, Nikolai Kondrashov wrote:
>> Hi everyone,
>> Here is a patch set fixing some things in integration tests and adding more
>> LDAP tests:
>> * Adding/removing a user/group/membership with rfc2307(bis) schema.
>> * Filtering users/groups with rfc2307(bis) schema.
>> * The effect of override_homedir option.
>> * The effect of fallback_homedir option.
>> * The effect of override_shell option.
>> * The effect of shell_fallback option.
>> * The effect of default_shell option.
>> * The effect of vetoed_shells option.
>> These are pretty basic, but I think they're good for the start.
>> Suggestions for more tests are welcome :)
>> NOTE: These still break test_memory_cache.py as seen in the attached log file.
>> We need to figure out why and do something with it. Otherwise, the
>> tests work fine.
> Here's another version of the patch set. It's not complete, but takes some
> comments into account. Namely:
> * Explicitly name the new arguments for ldap_ent.user and
> ldap_ent.List.add_user, instead of using "kwargs". Add
"gecos" too. This
> makes the function more suitable for Pavel Reichl's needs.
> * Don't remove "_rfc2307" from function names anywhere.
> * Use a string "schema" argument with configuration formatting
> instead of boolean "bis" argument to support other schemas. Use
> constants to specify the values in invocations.
> * Explicitly specify "enum" argument name when invoking configuration
> formatting functions.
> * Remove duplicate "blank" fixture function.
> I'll continue working on the patch set. Namely adding tests without
> enumeration, looking for and fixing the memory cache test failures induced by
> the new tests, trying to move commonly used fixtures and other functions to a
> module so we don't copy them.
The problem with failing test_add_remove_user after changing order with
test_memorycache is fixed with this patch set.
Hmm, curioser and curioser. I have no idea what that was.
It would good to push
first 5 patches so we can avoid conflicts with other patches.
Then we can focus on inter test failures.
Sure, good idea.
First 5 patches looks good to me.
But there are still new pep8 warnings
git diff HEAD~6..HEAD~ | pep8 --diff | wc -l
Yes, I was leaving that for today, forgot to mention above.