On Fri, Jan 16, 2015 at 02:06:20PM +0100, Jakub Hrozek wrote:
On Wed, Dec 17, 2014 at 01:36:01PM +0100, Pavel Březina wrote:
On 12/16/2014 01:19 PM, Pavel Březina wrote:
I realized that I forgot to add support for having both direct object path and fallback defined. I.e.:
/org/freedesktop/sssd/infopipe /org/freedesktop/sssd/infopipe/*
And one more time. While working on some improvements on ifp and sbus code I found out that there are some copy & paste relics in the last patch. Now they are gone.
There are some Coverity warnings: http://cov01.lab.eng.brq.redhat.com/covscanhub/task/16341/log/fixed.err
Sorry about sending an internal link. I'll paste the warnings instead: Error: DEADCODE (CWE-561): sssd-1.12.90/src/sbus/sssd_dbus_connection.c:515: string_non_null: String literal ""org.freedesktop.DBus.Error.NoMemory"" is never null. sssd-1.12.90/src/sbus/sssd_dbus_connection.c:515: assignment: Assigning: "dbus_error" = ""org.freedesktop.DBus.Error.NoMemory"". sssd-1.12.90/src/sbus/sssd_dbus_connection.c:507: string_non_null: String literal ""org.freedesktop.DBus.Error.NotSupported"" is never null. sssd-1.12.90/src/sbus/sssd_dbus_connection.c:507: assignment: Assigning: "dbus_error" = ""org.freedesktop.DBus.Error.NotSupported"". sssd-1.12.90/src/sbus/sssd_dbus_connection.c:527: string_non_null: String literal ""org.freedesktop.DBus.Error.NotSupported"" is never null. sssd-1.12.90/src/sbus/sssd_dbus_connection.c:527: assignment: Assigning: "dbus_error" = ""org.freedesktop.DBus.Error.NotSupported"". sssd-1.12.90/src/sbus/sssd_dbus_connection.c:538: string_non_null: String literal ""org.freedesktop.DBus.Error.NotSupported"" is never null. sssd-1.12.90/src/sbus/sssd_dbus_connection.c:538: assignment: Assigning: "dbus_error" = ""org.freedesktop.DBus.Error.NotSupported"". sssd-1.12.90/src/sbus/sssd_dbus_connection.c:501: string_non_null: String literal ""org.freedesktop.DBus.Error.UnknownMethod"" is never null. sssd-1.12.90/src/sbus/sssd_dbus_connection.c:501: assignment: Assigning: "dbus_error" = ""org.freedesktop.DBus.Error.UnknownMethod"". sssd-1.12.90/src/sbus/sssd_dbus_connection.c:562: notnull: At condition "dbus_error", the value of "dbus_error" cannot be "NULL". sssd-1.12.90/src/sbus/sssd_dbus_connection.c:562: dead_error_condition: The condition "dbus_error" must be true. sssd-1.12.90/src/sbus/sssd_dbus_connection.c:562: dead_error_line: Execution cannot reach the expression ""org.freedesktop.DBus.Error.Failed"" inside this statement: "reply = dbus_message_new_er...".
CI passed: http://sssd-ci.duckdns.org/logs/commit/38/75be1d2555a53b6df26d602324ccc431a5...