-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01/21/2010 10:08 AM, Sumit Bose wrote:
On Fri, Jan 08, 2010 at 03:30:32PM +0100, Sumit Bose wrote:
> On Fri, Jan 08, 2010 at 03:10:21PM +0100, Tomas Mraz wrote:
>> On Fri, 2010-01-08 at 15:01 +0100, Sumit Bose wrote:
>>> Hi,
>>>
>>> this patch just renames PAM_USER_INFO to PAM_SYSTEM_INFO. Currently
>>> PAM_USER_INFO is only used to send messages which are written to syslog
>>> by the PAM client. It is planned to add new messages which will be
>>> displayed to the user, e.g. if offline authentication was used. To avoid
>>> confusion I think this name change makes sense.
>>
>> I suggest to rename all the PAM_ prefixed constants which do not come
>> from PAM library directly to SSSPAM_ prefix to avoid confusion or name
>> conflict with the PAM library. Although I understand that is possibly an
>> API break.
>>
>
> I like this idea, I'll try to prepare a patch for this.
>
I have added a new patch which changes all defines and enum values
starting with PAM_ to SSS_PAM_. For your convenience I've added to
original patch, too.
bye,
Sumit
Please rebase this patch. It conflicts with the 32-bit memory alignment
patch already in master.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAktfCEgACgkQeiVVYja6o6OmuACfeme3Vyy5HZpCgL/enbRmQqIT
kecAn3FUW23NHWnmh8OKWm/fra0p0QMs
=cY0l
-----END PGP SIGNATURE-----