On 10/05/2016 03:47 PM, Philip Prindeville wrote:
On Oct 5, 2016, at 7:18 AM, Michal Židek mzidek@redhat.com wrote:
I forgot to attach the patches.
Again the first one is acked by me, the second needs a review.
Michal
Thanks for writing those tests.
Minor comment, dhash_ut_check.c and the existing checks don’t have any negative tests, such as attempting to delete a non-existent key, or deleting an already deleted key… or entering a key which is already present.
-Philip
Good point. I added some delete operations to these tests. However these are just some sanity tests to cover the code that was changed. My intention was not to test everything here.
New tests are attached.
Michal