On Fri, Oct 11, 2013 at 09:42:05AM -0400, Simo Sorce wrote:
Finally if everybody agree they want to make this huge change, *then* I absolutely want to see each change also change debug numbers from numbers to the new macros. It makes no sense whatsoever to change the DEBUG form and leave in old debug numbers that we have been painstakingly changing little by little in the last few years.
Sorry, forgot to reply here as well..
I would actually prefer *not* to mass-convert the decimal debug levels, everywhere.
The reason is that in the past we've used the levels quite randomly, so there is a lot of debug messages of not much importance with levels 1-3 and really a lot of messages with level 9, which should be mostly used by stuff like DBus tracing or ldb debug messages.
I think that with the decimal numbers in place, the developer is much more likely to notice that a decimal level needs to be changed and change its level as appropriate that if there already was a hexa debug level, but wrong.
I would agree with mass-converting (and then checking) modules that we are very stable and we are unlikely to touch them soon (sbus, confdb, the monitor itself, ...)