On Sun, Nov 18, 2012 at 10:29:46PM +0100, Jakub Hrozek wrote:
On Sun, Nov 18, 2012 at 03:54:54PM -0500, Simo Sorce wrote:
On Sun, 2012-11-18 at 18:27 +0100, Jakub Hrozek wrote:
On Sun, Nov 18, 2012 at 06:05:45PM +0100, Sumit Bose wrote:
On Fri, Nov 16, 2012 at 04:25:41PM -0500, Simo Sorce wrote:
Sumit found 2 issues in the patch.
- the 2 new wrapper proptotypes used _res as variable names but that symbol is now used in glibc: /usr/include/resolv.h:#define _res (*__res_state())
Changed to 'res'
- I was still using const char *src_name but it is unnecessary
Dropped the const
This should be hte last revision (last famous words :-)
:-)
ACK
bye, Sumit
I can't apply patch 3 on top of origin/master, can you rebase? _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Have you applied this https://patchwork.acksyn.org/patch/336/ patch first ?
It's a dependency.
Simo.
No, sorry, I forgot. I'll get it reviewed so that we can push this patchset.
Sumit did the upgrade patch review and I pushed all three patches in this thread to master and sssd-1-9