URL:
https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
sumit-bose commented:
"""
> Thanks. From functional point of view this now looks good.
> I'm really not sure about implementation of FO code changes though.
> Do we actually need to go to FO code? Can't we handle `retry_same_server` right
inside `sdap_cli_resolve_next()`?
It's possible but I am not sure if that's better than the actual implementation.
@sumit-bose what do you think? Should I move the retry logic from
`be_resolve_server_send()` to `sdap_cli_resolve_next()` as Alexey suggests?
Hi,
in general yes, but I wonder what would be the benefits? Having it in
`be_resolve_server_send()` makes the handling of the tevent request quite easy and it
would allow other callers to use `retry_same_server` as well, although we currently do not
have use-cases for this.
bye,
Sumit
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5532#issuecomment-813941302