On 11/23/2015 04:32 PM, Petr Spacek wrote:
On 23.11.2015 13:53, Pavel Reichl wrote:
On 11/20/2015 05:35 PM, Jakub Hrozek wrote:
On Fri, Nov 20, 2015 at 03:57:04PM +0100, Pavel Reichl wrote:
Hello,
please see attached patch.
Thanks!
Could you ask Petr Spacek to do a conceptual review? Somebody else (me of noone else is interested) can then do the code-review but I don't think our team has as good experience in handling nsupdate details..
Hello Petr, could you do the conceptual review as Jakub wishes?
I hope it should not be too hard as what we change in the patches is generation of a textual message for nsupdate and it's tested I dare to say thoroughly.
Sure, just send me a link :-) I do not see it the message above.
Sure, hope the link will work for you:
https://lists.fedorahosted.org/archives/list/sssd-devel%40lists.fedorahosted...
On (23/11/15 16:42), Pavel Reichl wrote:
On 11/23/2015 04:32 PM, Petr Spacek wrote:
On 23.11.2015 13:53, Pavel Reichl wrote:
On 11/20/2015 05:35 PM, Jakub Hrozek wrote:
On Fri, Nov 20, 2015 at 03:57:04PM +0100, Pavel Reichl wrote:
Hello,
please see attached patch.
Thanks!
Could you ask Petr Spacek to do a conceptual review? Somebody else (me of noone else is interested) can then do the code-review but I don't think our team has as good experience in handling nsupdate details..
Hello Petr, could you do the conceptual review as Jakub wishes?
I hope it should not be too hard as what we change in the patches is generation of a textual message for nsupdate and it's tested I dare to say thoroughly.
Sure, just send me a link :-) I do not see it the message above.
Sure, hope the link will work for you:
https://lists.fedorahosted.org/archives/list/sssd-devel%40lists.fedorahosted...
Thank you very much for updating desing page. Some parts are not clear to me.
You added following lines after first send into "Fallback attempt" ;sever is present only if option dyndns_server is set in sssd.conf server 192.168.122.20 ;realm is used always in fallback message realm IPA.WORK
But in other part of thread you wrote: "It was not a bug at the moment when document was written. It became a bug when we had to call nsupdate for each transaction separately - before that it was rather optimization."
What do you mean by transaction? It's not mentioned in design document.
Does it mean that nsupdate is called twice for updates in section "Fallback attempt"?
If it is called twice that it would be good to separate them into two boxes.
If it is not called twice then I do not undersand why it was not bug before.
LS
PS: it would be good to also update the section "How To Test". It's very brief. and does not reflect latest changes in design document.
On (24/11/15 16:06), Lukas Slebodnik wrote:
On (23/11/15 16:42), Pavel Reichl wrote:
On 11/23/2015 04:32 PM, Petr Spacek wrote:
On 23.11.2015 13:53, Pavel Reichl wrote:
On 11/20/2015 05:35 PM, Jakub Hrozek wrote:
On Fri, Nov 20, 2015 at 03:57:04PM +0100, Pavel Reichl wrote:
Hello,
please see attached patch.
Thanks!
Could you ask Petr Spacek to do a conceptual review? Somebody else (me of noone else is interested) can then do the code-review but I don't think our team has as good experience in handling nsupdate details..
Hello Petr, could you do the conceptual review as Jakub wishes?
I hope it should not be too hard as what we change in the patches is generation of a textual message for nsupdate and it's tested I dare to say thoroughly.
Sure, just send me a link :-) I do not see it the message above.
Sure, hope the link will work for you:
https://lists.fedorahosted.org/archives/list/sssd-devel%40lists.fedorahosted...
Thank you very much for updating desing page. Some parts are not clear to me.
You added following lines after first send into "Fallback attempt" ;sever is present only if option dyndns_server is set in sssd.conf server 192.168.122.20 ;realm is used always in fallback message realm IPA.WORK
But in other part of thread you wrote: "It was not a bug at the moment when document was written. It became a bug when we had to call nsupdate for each transaction separately - before that it was rather optimization."
What do you mean by transaction? It's not mentioned in design document.
Does it mean that nsupdate is called twice for updates in section "Fallback attempt"?
If it is called twice that it would be good to separate them into two boxes.
If it is not called twice then I do not undersand why it was not bug before.
LS
PS: it would be good to also update the section "How To Test". It's very brief. and does not reflect latest changes in design document.
It seems that we forgot about this thread.
Pavel, you would you mind to update desing page. It would be goof to have desing pages which does not have any confusing parts.
Thank you very much in advance.
LS
sssd-devel@lists.fedorahosted.org