[PATCH] CONFIGURE: Remove bashism

[Lukas Slebodnik]

ehlo,

simple patch is attached.

LS

[Nikolai Kondrashov]

On 09/25/2015 09:13 AM, Lukas Slebodnik wrote:
> There were errors in configure script when /bin/sh was not bash
> ./configure: 15889: test: xfedora: unexpected operator
> ./configure: 19981: test: xyes: unexpected operator
> ./configure: 23103: test: x1: unexpected operator
>
> The equality operator "==" works in bash but it's not a standard.
> The man page test(1) also does not mention it.
> There is only short version "="
>     STRING1 = STRING2
>            the strings are equal

This looks fine and justified to me.

ACK

Thank you, Lukas.

Nick

[Lukas Slebodnik]

On (25/09/15 15:05), Nikolai Kondrashov wrote:
> On 09/25/2015 09:13 AM, Lukas Slebodnik wrote:
> > There were errors in configure script when /bin/sh was not bash
> > ./configure: 15889: test: xfedora: unexpected operator
> > ./configure: 19981: test: xyes: unexpected operator
> > ./configure: 23103: test: x1: unexpected operator
> >
> > The equality operator "==" works in bash but it's not a standard.
> > The man page test(1) also does not mention it.
> > There is only short version "="
> >    STRING1 = STRING2
> >           the strings are equal
>
> This looks fine and justified to me.
>
> ACK
>
> Thank you, Lukas.

Thank you for review.

LS

[Lukas Slebodnik]

On (25/09/15 15:05), Nikolai Kondrashov wrote:
> On 09/25/2015 09:13 AM, Lukas Slebodnik wrote:
> > There were errors in configure script when /bin/sh was not bash
> > ./configure: 15889: test: xfedora: unexpected operator
> > ./configure: 19981: test: xyes: unexpected operator
> > ./configure: 23103: test: x1: unexpected operator
> >
> > The equality operator "==" works in bash but it's not a standard.
> > The man page test(1) also does not mention it.
> > There is only short version "="
> >    STRING1 = STRING2
> >           the strings are equal
>
> This looks fine and justified to me.
>
> ACK

http://sssd-ci.duckdns.org/logs/job/27/95/summary.html

* master: d9378e64499642e86989158f274372187314d5b2

LS

[Pavel Reichl]

On 09/26/2015 09:53 PM, Lukas Slebodnik wrote:
> On (25/09/15 15:05), Nikolai Kondrashov wrote:
> > On 09/25/2015 09:13 AM, Lukas Slebodnik wrote:
> > > There were errors in configure script when /bin/sh was not bash
> > > ./configure: 15889: test: xfedora: unexpected operator
> > > ./configure: 19981: test: xyes: unexpected operator
> > > ./configure: 23103: test: x1: unexpected operator
> > >
> > > The equality operator "==" works in bash but it's not a standard.
> > > The man page test(1) also does not mention it.
> > > There is only short version "="
> > >     STRING1 = STRING2
> > >            the strings are equal
> >
> > This looks fine and justified to me.
> >
> > ACK
>
> http://sssd-ci.duckdns.org/logs/job/27/95/summary.html
> master: d9378e64499642e86989158f274372187314d5b2
>
> LS
> _______________________________________________
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

It seems that you forget to add tag 'Reviewed-by'.