[PATCH] Clean up warnings in dhash tests

[Stephen Gallagher]

Original warnings:

../../../common/dhash/dhash_test.c: In function ‘main’:
../../../common/dhash/dhash_test.c:288: warning: declaration of ‘i’
shadows a previous local
../../../common/dhash/dhash_test.c:115: warning: shadowed declaration is
here
../../../common/dhash/dhash_test.c:312: warning: declaration of ‘i’
shadows a previous local
../../../common/dhash/dhash_test.c:115: warning: shadowed declaration is
here
../../../common/dhash/dhash_test.c:332: warning: declaration of ‘i’
shadows a previous local
../../../common/dhash/dhash_test.c:115: warning: shadowed declaration is
here
../../../common/dhash/dhash_example.c: In function ‘main’:
../../../common/dhash/dhash_example.c:44: warning: passing argument 2 of
‘new_data’ discards qualifiers from pointer target type
../../../common/dhash/dhash_example.c:28: note: expected ‘char *’ but
argument is of type ‘const char *’
../../../common/dhash/dhash_example.c:55: warning: assignment discards
qualifiers from pointer target type
../../../common/dhash/dhash_example.c:76: warning: assignment discards
qualifiers from pointer target type
../../../common/dhash/dhash_example.c:94: warning: declaration of
‘my_data’ shadows a previous local
../../../common/dhash/dhash_example.c:44: warning: shadowed declaration
is here
../../../common/dhash/dhash_example.c:105: warning: assignment discards
qualifiers from pointer target type

[Sumit Bose]

On Thu, Oct 29, 2009 at 01:43:06PM -0400, Stephen Gallagher wrote:
> Original warnings:
>
> ../../../common/dhash/dhash_test.c: In function ‘main’:
> ../../../common/dhash/dhash_test.c:288: warning: declaration of ‘i’
> shadows a previous local
> ../../../common/dhash/dhash_test.c:115: warning: shadowed declaration is
> here
> ../../../common/dhash/dhash_test.c:312: warning: declaration of ‘i’
> shadows a previous local
> ../../../common/dhash/dhash_test.c:115: warning: shadowed declaration is
> here
> ../../../common/dhash/dhash_test.c:332: warning: declaration of ‘i’
> shadows a previous local
> ../../../common/dhash/dhash_test.c:115: warning: shadowed declaration is
> here
> ../../../common/dhash/dhash_example.c: In function ‘main’:
> ../../../common/dhash/dhash_example.c:44: warning: passing argument 2 of
> ‘new_data’ discards qualifiers from pointer target type
> ../../../common/dhash/dhash_example.c:28: note: expected ‘char *’ but
> argument is of type ‘const char *’
> ../../../common/dhash/dhash_example.c:55: warning: assignment discards
> qualifiers from pointer target type
> ../../../common/dhash/dhash_example.c:76: warning: assignment discards
> qualifiers from pointer target type
> ../../../common/dhash/dhash_example.c:94: warning: declaration of
> ‘my_data’ shadows a previous local
> ../../../common/dhash/dhash_example.c:44: warning: shadowed declaration
> is here
> ../../../common/dhash/dhash_example.c:105: warning: assignment discards
> qualifiers from pointer target type
>
> -- 
> Stephen Gallagher
> RHCE 804006346421761
>
> Delivering value year after year.
> Red Hat ranks #1 in value among software vendors.
> http://www.redhat.com/promo/vendor/

warnings are gone and dhash_example still works,

ACK

Maybe we should wait for a comment from John before pushing it?

bye,
Sumit

[John Dennis]

On 10/29/2009 01:43 PM, Stephen Gallagher wrote:
> Original warnings:
>
> ../../../common/dhash/dhash_test.c: In function ‘main’:
> ../../../common/dhash/dhash_test.c:288: warning: declaration of ‘i’
> shadows a previous local
> ../../../common/dhash/dhash_test.c:115: warning: shadowed declaration is
> here
> ../../../common/dhash/dhash_test.c:312: warning: declaration of ‘i’
> shadows a previous local
> ../../../common/dhash/dhash_test.c:115: warning: shadowed declaration is
> here
> ../../../common/dhash/dhash_test.c:332: warning: declaration of ‘i’
> shadows a previous local
> ../../../common/dhash/dhash_test.c:115: warning: shadowed declaration is
> here
> ../../../common/dhash/dhash_example.c: In function ‘main’:
> ../../../common/dhash/dhash_example.c:44: warning: passing argument 2 of
> ‘new_data’ discards qualifiers from pointer target type
> ../../../common/dhash/dhash_example.c:28: note: expected ‘char *’ but
> argument is of type ‘const char *’
> ../../../common/dhash/dhash_example.c:55: warning: assignment discards
> qualifiers from pointer target type
> ../../../common/dhash/dhash_example.c:76: warning: assignment discards
> qualifiers from pointer target type
> ../../../common/dhash/dhash_example.c:94: warning: declaration of
> ‘my_data’ shadows a previous local
> ../../../common/dhash/dhash_example.c:44: warning: shadowed declaration
> is here
> ../../../common/dhash/dhash_example.c:105: warning: assignment discards
> qualifiers from pointer target type

ACK

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/29/2009 02:55 PM, John Dennis wrote:
> On 10/29/2009 01:43 PM, Stephen Gallagher wrote:
> > Original warnings:
> >
> > ../../../common/dhash/dhash_test.c: In function ‘main’:
> > ../../../common/dhash/dhash_test.c:288: warning: declaration of ‘i’
> > shadows a previous local
> > ../../../common/dhash/dhash_test.c:115: warning: shadowed declaration is
> > here
> > ../../../common/dhash/dhash_test.c:312: warning: declaration of ‘i’
> > shadows a previous local
> > ../../../common/dhash/dhash_test.c:115: warning: shadowed declaration is
> > here
> > ../../../common/dhash/dhash_test.c:332: warning: declaration of ‘i’
> > shadows a previous local
> > ../../../common/dhash/dhash_test.c:115: warning: shadowed declaration is
> > here
> > ../../../common/dhash/dhash_example.c: In function ‘main’:
> > ../../../common/dhash/dhash_example.c:44: warning: passing argument 2 of
> > ‘new_data’ discards qualifiers from pointer target type
> > ../../../common/dhash/dhash_example.c:28: note: expected ‘char *’ but
> > argument is of type ‘const char *’
> > ../../../common/dhash/dhash_example.c:55: warning: assignment discards
> > qualifiers from pointer target type
> > ../../../common/dhash/dhash_example.c:76: warning: assignment discards
> > qualifiers from pointer target type
> > ../../../common/dhash/dhash_example.c:94: warning: declaration of
> > ‘my_data’ shadows a previous local
> > ../../../common/dhash/dhash_example.c:44: warning: shadowed declaration
> > is here
> > ../../../common/dhash/dhash_example.c:105: warning: assignment discards
> > qualifiers from pointer target type
>
> ACK

Pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkrp7I0ACgkQeiVVYja6o6PrrgCgmT53UylFCgNKQrz/YU2Dsg/l
> VmsAoJloGCNameGKkgpIpsMmcsh/qAci
> =jZcm
> -----END PGP SIGNATURE-----