URL: https://github.com/SSSD/sssd/pull/841 Author: thalman Title: #841: DEBUG: Add debug to display ldapsearch requests Action: opened
PR body: """ The existing debug output from SSSD is quite helpful in this respect, but it would be better if a small enhancement were made so that for a specific debug level SSSD would print out all the details of the LDAP search it is doing, ie the LDAP server, the base dn, the scope, filter and attributes requested.
Server address is already in the log nowadays so this change writes missing search scope. Also received attributes are logged with SSSDBG_TRACE_LIBS debug level.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1542137 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/841/head:pr841 git checkout pr841
URL: https://github.com/SSSD/sssd/pull/841 Author: thalman Title: #841: WIP DEBUG: Add debug to display ldapsearch requests Action: edited
Changed field: title Original value: """ DEBUG: Add debug to display ldapsearch requests """
URL: https://github.com/SSSD/sssd/pull/841 Author: thalman Title: #841: DEBUG: Add debug to display ldapsearch requests Action: edited
Changed field: title Original value: """ WIP DEBUG: Add debug to display ldapsearch requests """
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
jhrozek commented: """ The code looks OK. I haven't tried it, but looks simple enough.
But most importantly, it is not enough to resolve the issue, I think. What the original reporter asked for was a way to filter only these messages. And we can either add a special debug level, but wouldn't it be even better to add systemtap messages? See commits like d46d59e78600aa72176df7217c94743b7e71881a 1182dd93a5a6bb18943284273f7fd59b83468843 and f199c749197532fd3380fa6f5d9f7a579879c21a to see how we added some generic instrumentation to the DP.. """
See the full comment at https://github.com/SSSD/sssd/pull/841#issuecomment-516766392
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/841 Author: thalman Title: #841: DEBUG: Add debug to display ldapsearch requests Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/841/head:pr841 git checkout pr841
URL: https://github.com/SSSD/sssd/pull/841 Author: thalman Title: #841: DEBUG: Add debug to display ldapsearch requests Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/841/head:pr841 git checkout pr841
URL: https://github.com/SSSD/sssd/pull/841 Author: thalman Title: #841: DEBUG: Add debug to display ldapsearch requests Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/841/head:pr841 git checkout pr841
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/841 Author: thalman Title: #841: DEBUG: Add debug to display ldapsearch requests Action: edited
Changed field: body Original value: """ The existing debug output from SSSD is quite helpful in this respect, but it would be better if a small enhancement were made so that for a specific debug level SSSD would print out all the details of the LDAP search it is doing, ie the LDAP server, the base dn, the scope, filter and attributes requested.
Server address is already in the log nowadays so this change writes missing search scope. Also received attributes are logged with SSSDBG_TRACE_LIBS debug level.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1542137 """
URL: https://github.com/SSSD/sssd/pull/841 Author: thalman Title: #841: DEBUG: Add debug to display ldapsearch requests Action: edited
Changed field: body Original value: """ The existing debug output from SSSD is quite helpful in this respect, but it would be better to have systemtap probes that can monitor executed LDAP search calls and display returned results.
Two new probes are created (SDAP_PARSE_ENTRY, SDAP_PARSE_ENTRY_DONE) in this PR to expose received attributes. The probe SDAP_GET_GENERIC_EXT_SEND is extended of requested attributes list.
Thee systemtap script contrib/systemtap/ldap_perf.stp can be used to monitor LDAP queries.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1542137 """
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
mzidek-rh commented: """ Assigning to myself for now, but I will get to this probably on Monday. If someone wants to review it sooner feel free to re-assign to yourself. """
See the full comment at https://github.com/SSSD/sssd/pull/841#issuecomment-543050260
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
mzidek-rh commented: """ As per offline IRC discussion Tomas will add one more commit for man page change. Adding changes requested for now. """
See the full comment at https://github.com/SSSD/sssd/pull/841#issuecomment-545017299
URL: https://github.com/SSSD/sssd/pull/841 Author: thalman Title: #841: DEBUG: Add debug to display ldapsearch requests Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/841/head:pr841 git checkout pr841
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
thalman commented: """
As per offline IRC discussion Tomas will add one more commit for man page change. Adding changes requested for now.
Man page extended of list of sample scripts and their purpose. """
See the full comment at https://github.com/SSSD/sssd/pull/841#issuecomment-545069574
URL: https://github.com/SSSD/sssd/pull/841 Author: thalman Title: #841: DEBUG: Add debug to display ldapsearch requests Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/841/head:pr841 git checkout pr841
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
mzidek-rh commented: """ Please add the new script to the Makefile.am here: ``` 1519 dist_sssdtapscript_DATA = \ 1520 contrib/systemtap/id_perf.stp \ 1521 contrib/systemtap/nested_group_perf.stp \ 1522 contrib/systemtap/dp_request.stp \ 1523 $(NULL) ```
And to the contrib/sssd.spec.in file here: ``` 1081 %dir %{_datadir}/sssd/systemtap 1082 %{_datadir}/sssd/systemtap/id_perf.stp 1083 %{_datadir}/sssd/systemtap/nested_group_perf.stp 1084 %{_datadir}/sssd/systemtap/dp_request.stp ```
Other than that it LGTM. """
See the full comment at https://github.com/SSSD/sssd/pull/841#issuecomment-545484187
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/841 Author: thalman Title: #841: DEBUG: Add debug to display ldapsearch requests Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/841/head:pr841 git checkout pr841
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
thalman commented: """ retest this, please """
See the full comment at https://github.com/SSSD/sssd/pull/841#issuecomment-548426370
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
thalman commented: """ Well, I don't see any error in logs, looks like CI issue, running retest for CentOS. """
See the full comment at https://github.com/SSSD/sssd/pull/841#issuecomment-548427482
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
mzidek-rh commented: """ ACK """
See the full comment at https://github.com/SSSD/sssd/pull/841#issuecomment-549452286
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
pbrezina commented: """ * `master` * c7c08e12c15509d1a515e02d591d9c5c8e298802 - MAN: Update SystemTap man page * c7909707471adaf7b3477a9e4dfc7bc91b0a256e - TESTS: tests have to be linked with systemtap * c4568a9a94c6aff497dfd2a277cfc989780c6c0c - MAN: update systemtap man page * 88b875f6b376ef46b3ed0e72a1508c6d206a62e4 - LDAP: Add probes to be able print ldap attributes * 7fd907cbe77e781c053e74ddd3c6c5a59a26788c - LDAP: extend LDAP systemtap probes of attr list * 44d46cf283a1b79f566f89e62190a6189e682c66 - LDAP: Systemtap ldap probes fail without filter
"""
See the full comment at https://github.com/SSSD/sssd/pull/841#issuecomment-549767043
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/841 Title: #841: DEBUG: Add debug to display ldapsearch requests
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/841 Author: thalman Title: #841: DEBUG: Add debug to display ldapsearch requests Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/841/head:pr841 git checkout pr841
sssd-devel@lists.fedorahosted.org
-
jhrozek -
mzidek-rh
-
pbrezina
-
thalman