[PATCH] Autofs Coverity issues

[Jakub Hrozek]

[PATCH 1/2] Autofs: operate on contents of double-pointer, not address
This is a bad one, luckily the code is defensive later on and detects
that we have processed all the records and quits correctly.

[PATCH 2/2] Only free returned values on success
The pointers are set to NULL when the map is not found or the code
iterates over all the maps, but it is good manners to only free the data
when the caller is sure he received any.

[Jan Zelený]

> [PATCH 1/2] Autofs: operate on contents of double-pointer, not address
> This is a bad one, luckily the code is defensive later on and detects
> that we have processed all the records and quits correctly.
>
> [PATCH 2/2] Only free returned values on success
> The pointers are set to NULL when the map is not found or the code
> iterates over all the maps, but it is good manners to only free the data
> when the caller is sure he received any.

Ack to both

Jan

[Stephen Gallagher]

On Wed, 2012-03-07 at 15:20 +0100, Jan Zelený wrote:
> > [PATCH 1/2] Autofs: operate on contents of double-pointer, not address
> > This is a bad one, luckily the code is defensive later on and detects
> > that we have processed all the records and quits correctly.
> >
> > [PATCH 2/2] Only free returned values on success
> > The pointers are set to NULL when the map is not found or the code
> > iterates over all the maps, but it is good manners to only free the data
> > when the caller is sure he received any.
>
> Ack to both

Ack and pushed to master and sssd-1-8.