[sssd PR#634][opened] P11: Don't return int failure from a bool function

[jhrozek]

   URL: https://github.com/SSSD/sssd/pull/634
Author: jhrozek
 Title: #634: P11: Don't return int failure from a bool function
Action: opened

PR body:
"""
The functions return bool as per their prototype, but returning EINVAL on
failure meant that EINVAL (typically 22) was converted to 'true', so a
certificate that was not processable was considered valid.

Luckily this code only converts certificates into SSH public keys, so there
are no security implications.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/634/head:pr634
git checkout pr634

[sssd PR#634][comment] P11: Don't return int failure from a bool function

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/634
Title: #634: P11: Don't return int failure from a bool function

pbrezina commented:
"""
Obvious ack.
"""

See the full comment at https://github.com/SSSD/sssd/pull/634#issuecomment-412081632

[sssd PR#634][comment] P11: Don't return int failure from a bool function

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/634
Title: #634: P11: Don't return int failure from a bool function

sumit-bose commented:
"""
ACK from me as well.
"""

See the full comment at https://github.com/SSSD/sssd/pull/634#issuecomment-412103322

[sssd PR#634][+Accepted] P11: Don't return int failure from a bool function

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/634
Title: #634: P11: Don't return int failure from a bool function

Label: +Accepted

[sssd PR#634][comment] P11: Don't return int failure from a bool function

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/634
Title: #634: P11: Don't return int failure from a bool function

fidencio commented:
"""
master:
 7225bab
"""

See the full comment at https://github.com/SSSD/sssd/pull/634#issuecomment-412120291

[sssd PR#634][closed] P11: Don't return int failure from a bool function

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/634
Author: jhrozek
 Title: #634: P11: Don't return int failure from a bool function
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/634/head:pr634
git checkout pr634

[sssd PR#634][+Pushed] P11: Don't return int failure from a bool function

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/634
Title: #634: P11: Don't return int failure from a bool function

Label: +Pushed

[sssd PR#634][-Accepted] P11: Don't return int failure from a bool function

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/634
Title: #634: P11: Don't return int failure from a bool function

Label: -Accepted