[sssd PR#532][opened] TESTS: Fix E501 pep8 issues on test_netgroup.py

[fidencio]

URL: https://github.com/SSSD/sssd/pull/532
Author: fidencio
 Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
Action: opened

PR body:
"""
E501: line too long (longer than 79 characters)

The issue was inserted in commit 0f8add07b8, which has been pushed just
before the pep8 patches got merged.

Signed-off-by: Fabiano Fidêncio 
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/532/head:pr532
git checkout pr532

[sssd PR#532][comment] TESTS: Fix E501 pep8 issues on test_netgroup.py

[fidencio]

URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py

fidencio commented:
"""
Just a note here ... knowing my python knowledge I'd say there are a few other ways to better solve this issue. So, please, give me your suggestion and I'll change the patch accordingly. :-)
"""

See the full comment at https://github.com/SSSD/sssd/pull/532#issuecomment-372224702

[sssd PR#532][comment] TESTS: Fix E501 pep8 issues on test_netgroup.py

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py

mzidek-rh commented:
"""
I pushed the patch to CI.

This issue blocks CI, so I will ACK it when the results are green. I am not python expert either, but the fix LGTM. If someone proposes better solution in the meantime we can go with that, but unblocking the tests is more important now.
"""

See the full comment at https://github.com/SSSD/sssd/pull/532#issuecomment-372265205

[sssd PR#532][comment] TESTS: Fix E501 pep8 issues on test_netgroup.py

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py

jhrozek commented:
"""
Feel free to push the patch as emergency to unblock the CI, but I admit I don't find the syntax very readable. What about:
```
--- a/src/tests/intg/test_netgroup.py
+++ b/src/tests/intg/test_netgroup.py
@@ -253,7 +253,9 @@ def test_add_tripled_netgroup(add_tripled_netgroup):
     assert sorted(netgrps) == sorted([("host1", "user1", "domain1"),
                                       ("host2", "user2", "domain2")])

-    res, _, netgrps = sssd_netgroup.get_sssd_netgroups("tripled_netgroup_no_domain")
+    res, _, netgrps = \
+            sssd_netgroup.get_sssd_netgroups("tripled_netgroup_no_domain")
+
     assert res == sssd_netgroup.NssReturnCode.SUCCESS
     assert netgrps == [("host", "user", "")]
```
"""

See the full comment at https://github.com/SSSD/sssd/pull/532#issuecomment-372270891

[sssd PR#532][synchronized] TESTS: Fix E501 pep8 issues on test_netgroup.py

[fidencio]

URL: https://github.com/SSSD/sssd/pull/532
Author: fidencio
 Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/532/head:pr532
git checkout pr532

[sssd PR#532][comment] TESTS: Fix E501 pep8 issues on test_netgroup.py

[fidencio]

URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py

fidencio commented:
"""
@jhrozek, I like your suggestion more than mine.

I've updated the patch and pushed it to our internal CI. I'll get back here as soon as I have the results.
"""

See the full comment at https://github.com/SSSD/sssd/pull/532#issuecomment-372276385

[sssd PR#532][comment] TESTS: Fix E501 pep8 issues on test_netgroup.py

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py

sumit-bose commented:
"""
With

diff --git a/src/tests/intg/test_netgroup.py b/src/tests/intg/test_netgroup.py
index 3cf5dac..5c36dc2 100644
--- a/src/tests/intg/test_netgroup.py
+++ b/src/tests/intg/test_netgroup.py
@@ -30,7 +30,8 @@ import config
 import ds_openldap
 import ldap_ent
 from util import unindent
-import sssd_netgroup
+from sssd_nss import NssReturnCode
+from sssd_netgroup import get_sssd_netgroups

you can remove 'sssd_netgroup.' all over the place.
"""

See the full comment at https://github.com/SSSD/sssd/pull/532#issuecomment-372278267

[sssd PR#532][comment] TESTS: Fix E501 pep8 issues on test_netgroup.py

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py

mzidek-rh commented:
"""
The last version does not work for me:
```
# PEP8_IGNORE="--ignore=E121,E123,E126,E226,E24,E704,W503"
# find ./src -path ./src/config -prune -o -name *.py -exec pep8 $PEP8_IGNORE {} +
./src/tests/intg/test_netgroup.py:248:13: E127 continuation line over-indented for visual indent
./src/tests/intg/test_netgroup.py:253:13: E127 continuation line over-indented for visual indent
./src/tests/intg/test_netgroup.py:259:13: E127 continuation line over-indented for visual indent
./src/tests/intg/test_netgroup.py:264:13: E127 continuation line over-indented for visual indent
./src/tests/intg/test_netgroup.py:269:13: E127 continuation line over-indented for visual indent
./src/tests/intg/test_netgroup.py:274:13: E127 continuation line over-indented for visual indent
```

+1 for @sumit-bose 's suggestion with import (if there is some issue even with this, then we can push the original patch as fallback to unblock the CI)
"""

See the full comment at https://github.com/SSSD/sssd/pull/532#issuecomment-372279616

[sssd PR#532][synchronized] TESTS: Fix E501 pep8 issues on test_netgroup.py

[fidencio]

URL: https://github.com/SSSD/sssd/pull/532
Author: fidencio
 Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/532/head:pr532
git checkout pr532

[sssd PR#532][comment] TESTS: Fix E501 pep8 issues on test_netgroup.py

[fidencio]

URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py

fidencio commented:
"""
Okay, let me go for Sumit's suggestion. ;-) I've updated the patch.
"""

See the full comment at https://github.com/SSSD/sssd/pull/532#issuecomment-372306534

[sssd PR#532][comment] TESTS: Fix E501 pep8 issues on test_netgroup.py

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py

mzidek-rh commented:
"""
Ok, I just pushed to last iteration to CI. If it is green I will ACK :)
"""

See the full comment at https://github.com/SSSD/sssd/pull/532#issuecomment-372315576

[sssd PR#532][comment] TESTS: Fix E501 pep8 issues on test_netgroup.py

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py

mzidek-rh commented:
"""
ACK.

CI results:
$SSSD_LAB.com/:8080/job/ci/8697/
"""

See the full comment at https://github.com/SSSD/sssd/pull/532#issuecomment-372600743

[sssd PR#532][+Accepted] TESTS: Fix E501 pep8 issues on test_netgroup.py

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py

Label: +Accepted

[sssd PR#532][comment] TESTS: Fix E501 pep8 issues on test_netgroup.py

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py

jhrozek commented:
"""
* master: cce64caa78d088d54c40e50b777b8a8ddd1a0c0a
"""

See the full comment at https://github.com/SSSD/sssd/pull/532#issuecomment-372605859

[sssd PR#532][closed] TESTS: Fix E501 pep8 issues on test_netgroup.py

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/532
Author: fidencio
 Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/532/head:pr532
git checkout pr532

[sssd PR#532][+Pushed] TESTS: Fix E501 pep8 issues on test_netgroup.py

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py

Label: +Pushed