8:36 a.m.
URL: https://github.com/SSSD/sssd/pull/27
Author: mzidek-rh
Title: #27: Minor code changes
Action: opened
PR body:
"""
Some small changes in the code.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/27/head:pr27
git checkout pr27
8:47 a.m.
New subject: [sssd PR#27][comment] Minor code changes
URL: https://github.com/SSSD/sssd/pull/27
Title: #27: Minor code changes
lslebodn commented:
"""
NACK to the first patch.
We should rather use ldap_err2string.
Adding more if/else statementes just complicate the code.
the 2nd patch would make sense if you would like to reuse
enum for other use-case which I cannot see in patch set.
If there is not such use-case I would prefer to keep curret name of enum.
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/27#issuecomment-247604790
9:26 a.m.
New subject: [sssd PR#27][+Changes requested] Minor code changes
URL: https://github.com/SSSD/sssd/pull/27
Title: #27: Minor code changes
Label: +Changes requested
4:41 a.m.
New subject: [sssd PR#27][synchronized] Minor code changes
URL: https://github.com/SSSD/sssd/pull/27
Author: mzidek-rh
Title: #27: Minor code changes
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/27/head:pr27
git checkout pr27
7:19 a.m.
New subject: [sssd PR#27][-Changes requested] Minor code changes
URL: https://github.com/SSSD/sssd/pull/27
Title: #27: Minor code changes
Label: -Changes requested
10:48 a.m.
New subject: [sssd PR#27][comment] Minor code changes
URL: https://github.com/SSSD/sssd/pull/27
Title: #27: Minor code changes
lslebodn commented:
"""
I finally tried the patch and here are logs before change
```
[sssd[be[LDAP]]] [sdap_get_generic_op_finished] (0x0400): Search result: Administrative
limit exceeded(11), no errmsg set
[sssd[be[LDAP]]] [sdap_get_generic_op_finished] (0x0080): LDAP sizelimit was exceeded,
returning incomplete data
```
and after change
```
[sssd[be[LDAP]]] [sdap_get_generic_op_finished] (0x0400): Search result: Administrative
limit exceeded(11), no errmsg set
[sssd[be[LDAP]]] [sdap_get_generic_op_finished] (0x0080): LDAP server limit was exceeded,
returning incomplete data: Administrative limit exceeded(11)
```
Personally, I do not see any benefit. I would prefer to reject the patch. I will wait few
days before closing this PR.
"""
See the full comment at https://github.com/SSSD/sssd/pull/27#issuecomment-262816103
10:49 a.m.
New subject: [sssd PR#27][+Rejected] Minor code changes
URL: https://github.com/SSSD/sssd/pull/27
Title: #27: Minor code changes
Label: +Rejected
3:12 p.m.
New subject: [sssd PR#27][comment] Minor code changes
URL: https://github.com/SSSD/sssd/pull/27
Title: #27: Minor code changes
lslebodn commented:
"""
There were not any objection => Closing
"""
See the full comment at https://github.com/SSSD/sssd/pull/27#issuecomment-264563800
3:12 p.m.
New subject: [sssd PR#27][closed] Minor code changes
URL: https://github.com/SSSD/sssd/pull/27
Author: mzidek-rh
Title: #27: Minor code changes
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/27/head:pr27
git checkout pr27
2695
days inactive
2772
days old
sssd-devel@lists.fedorahosted.org
8 comments
1 participants
participants (1)
-
fidencio