URL: https://github.com/SSSD/sssd/pull/27 Author: mzidek-rh Title: #27: Minor code changes Action: opened
PR body: """ Some small changes in the code. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/27/head:pr27 git checkout pr27
URL: https://github.com/SSSD/sssd/pull/27 Title: #27: Minor code changes
lslebodn commented: """ NACK to the first patch. We should rather use ldap_err2string. Adding more if/else statementes just complicate the code.
the 2nd patch would make sense if you would like to reuse enum for other use-case which I cannot see in patch set. If there is not such use-case I would prefer to keep curret name of enum.
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/27#issuecomment-247604790
URL: https://github.com/SSSD/sssd/pull/27 Title: #27: Minor code changes
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/27 Author: mzidek-rh Title: #27: Minor code changes Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/27/head:pr27 git checkout pr27
URL: https://github.com/SSSD/sssd/pull/27 Title: #27: Minor code changes
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/27 Title: #27: Minor code changes
lslebodn commented: """ I finally tried the patch and here are logs before change ``` [sssd[be[LDAP]]] [sdap_get_generic_op_finished] (0x0400): Search result: Administrative limit exceeded(11), no errmsg set [sssd[be[LDAP]]] [sdap_get_generic_op_finished] (0x0080): LDAP sizelimit was exceeded, returning incomplete data ```
and after change ``` [sssd[be[LDAP]]] [sdap_get_generic_op_finished] (0x0400): Search result: Administrative limit exceeded(11), no errmsg set [sssd[be[LDAP]]] [sdap_get_generic_op_finished] (0x0080): LDAP server limit was exceeded, returning incomplete data: Administrative limit exceeded(11) ```
Personally, I do not see any benefit. I would prefer to reject the patch. I will wait few days before closing this PR.
"""
See the full comment at https://github.com/SSSD/sssd/pull/27#issuecomment-262816103
URL: https://github.com/SSSD/sssd/pull/27 Title: #27: Minor code changes
Label: +Rejected
URL: https://github.com/SSSD/sssd/pull/27 Title: #27: Minor code changes
lslebodn commented: """ There were not any objection => Closing """
See the full comment at https://github.com/SSSD/sssd/pull/27#issuecomment-264563800
URL: https://github.com/SSSD/sssd/pull/27 Author: mzidek-rh Title: #27: Minor code changes Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/27/head:pr27 git checkout pr27
sssd-devel@lists.fedorahosted.org
-
fidencio