[sssd PR#563][opened] SYSDB: Only check non-POSIX groups for GID conflicts

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/563
Author: jhrozek
 Title: #563: SYSDB: Only check non-POSIX groups for GID conflicts
Action: opened

PR body:
"""
When checking for a GID conflict, it doesn't make sense to check for one
when the group being added is a non-POSIX one, because then the GID will
always be 0.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/563/head:pr563
git checkout pr563

[sssd PR#563][comment] SYSDB: Only check non-POSIX groups for GID conflicts

[fidencio]

URL: https://github.com/SSSD/sssd/pull/563
Title: #563: SYSDB: Only check non-POSIX groups for GID conflicts

fidencio commented:
"""
Hmm. The non-POSIX case just didn't come to my mind when writing the original patch down.
The patch looks good and I'm running the internal CI just for the sake of the process and I'll add the accepted label as soon as I get the results.
"""

See the full comment at https://github.com/SSSD/sssd/pull/563#issuecomment-386208411

[sssd PR#563][comment] SYSDB: Only check non-POSIX groups for GID conflicts

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/563
Title: #563: SYSDB: Only check non-POSIX groups for GID conflicts

jhrozek commented:
"""
> On 3 May 2018, at 09:09, fidencio  wrote:
>
> Hmm. The non-POSIX case just didn't come to my mind when writing the original patch down.

This is a part that I broke :-) I also didn’t think about the non-Posix groups and only saw the issue when I was running some manual tests with an IPA-AD trust setup.
> The patch looks good and I'm running the internal CI just for the sake of the process and I'll add the accepted label as soon as I get the results.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.

"""

See the full comment at https://github.com/SSSD/sssd/pull/563#issuecomment-386213430

[sssd PR#563][comment] SYSDB: Only check non-POSIX groups for GID conflicts

[fidencio]

URL: https://github.com/SSSD/sssd/pull/563
Title: #563: SYSDB: Only check non-POSIX groups for GID conflicts

fidencio commented:
"""
Ack!
CI: http://vm-031.$%7Babc%7D/logs/job/88/45/summary.html
"""

See the full comment at https://github.com/SSSD/sssd/pull/563#issuecomment-386409318

[sssd PR#563][+Accepted] SYSDB: Only check non-POSIX groups for GID conflicts

[fidencio]

URL: https://github.com/SSSD/sssd/pull/563
Title: #563: SYSDB: Only check non-POSIX groups for GID conflicts

Label: +Accepted

[sssd PR#563][comment] SYSDB: Only check non-POSIX groups for GID conflicts

[fidencio]

URL: https://github.com/SSSD/sssd/pull/563
Title: #563: SYSDB: Only check non-POSIX groups for GID conflicts

fidencio commented:
"""
master:
 8a8285c
"""

See the full comment at https://github.com/SSSD/sssd/pull/563#issuecomment-386420712

[sssd PR#563][closed] SYSDB: Only check non-POSIX groups for GID conflicts

[fidencio]

URL: https://github.com/SSSD/sssd/pull/563
Author: jhrozek
 Title: #563: SYSDB: Only check non-POSIX groups for GID conflicts
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/563/head:pr563
git checkout pr563

[sssd PR#563][+Pushed] SYSDB: Only check non-POSIX groups for GID conflicts

[fidencio]

URL: https://github.com/SSSD/sssd/pull/563
Title: #563: SYSDB: Only check non-POSIX groups for GID conflicts

Label: +Pushed

[sssd PR#563][-Accepted] SYSDB: Only check non-POSIX groups for GID conflicts

[fidencio]

URL: https://github.com/SSSD/sssd/pull/563
Title: #563: SYSDB: Only check non-POSIX groups for GID conflicts

Label: -Accepted