[sssd PR#144][opened] SSSD does not start if using only the local provider and services line is empty

[fidencio]

URL: https://github.com/SSSD/sssd/pull/144
Author: fidencio
 Title: #144: SSSD does not start if using only the local provider and services line is empty
Action: opened

PR body:
"""
SSSD has to notify systemd whenever its startup is finished. Currently it has been done only when a service (and here I mean either provider or responder) has been started up.

However, when dealing with socket-activation we have the case where no responders have been set up and, consequently, the sd_notify() code won't ever be triggered by the responders.
Combining the above described scenario with the user setting up only the LOCAL provider, which also won't trigger the sd_notify() code, SSSD can end up hitting a systemd timeout during initialization.

This patch set solve the described issue.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/144/head:pr144
git checkout pr144

[sssd PR#144][synchronized] SSSD does not start if using only the local provider and services line is empty

[fidencio]

URL: https://github.com/SSSD/sssd/pull/144
Author: fidencio
 Title: #144: SSSD does not start if using only the local provider and services line is empty
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/144/head:pr144
git checkout pr144

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

pbrezina commented:
"""
In general, I think we should finally create a dummy local provider so we can avoid special casing it all the time. I created a ticket for it: https://fedorahosted.org/sssd/ticket/3304

"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-277974313

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[fidencio]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

fidencio commented:
"""
Just to clarify, do you think we should go for the dummy local provider instead of this patch series? Or that we should also go for the dummy local provider?

What I'm trying to solve with this patch series is a way less complex change.
"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-277975809

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

lslebodn commented:
"""
On (07/02/17 03:46), fidencio wrote:
> Just to clarify, do you think we should go for the dummy local provider instead of this patch series? Or that we should also go for the dummy local provider?
>
> What I'm trying to solve with this patch series is a way less complex change.

maybe files provider will be a solution

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-277976075

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

pbrezina commented:
"""
@fidencio go with these patches, that is why I created a new ticket for dummy provider
@lslebodn with files provider I believe we can afford removing local provider completely.
"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-277977392

[sssd PR#144][+Accepted] SSSD does not start if using only the local provider and services line is empty

[fidencio]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

Label: +Accepted

[sssd PR#144][-Accepted] SSSD does not start if using only the local provider and services line is empty

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

Label: -Accepted

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

lslebodn commented:
"""
My intention was to wait for files provider and drop this PR.
But maybe I misunderstood something
"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-278009723

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

lslebodn commented:
"""
My intention was to wait for files provider and drop this PR.
But maybe I misunderstood something
"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-278009723

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[fidencio]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

fidencio commented:
"""
You did not mention anything in your comment, @lslebodn. While @pbrezina said "go with these patches".

I personally don't agree on leaving an issue opened for a few days (or weeks?) if there's an ACK patch ready to be pushed. But my opinion doesn't count much here ...

"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-278011114

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[fidencio]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

fidencio commented:
"""
You did not mention anything in your comment, @lslebodn. While @pbrezina said "go with these patches".

I personally don't agree on leaving an issue opened for a few days (or weeks?) if there's an ACKed patch ready to be pushed. But my opinion doesn't count much here ...

"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-278011114

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

pbrezina commented:
"""
Who knows which version will have local provider removed. Push these patches for now.
"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-278317970

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

pbrezina commented:
"""
I mean after changes requested in review are done.
"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-278318179

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[fidencio]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

fidencio commented:
"""
There were no changes requested during the review. Changing, again, this patchset to Accepted.
"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-278318469

[sssd PR#144][+Accepted] SSSD does not start if using only the local provider and services line is empty

[fidencio]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

Label: +Accepted

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

pbrezina commented:
"""
Sorry, I didn't push submit button. Darn github.
"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-278319650

[sssd PR#144][synchronized] SSSD does not start if using only the local provider and services line is empty

[fidencio]

URL: https://github.com/SSSD/sssd/pull/144
Author: fidencio
 Title: #144: SSSD does not start if using only the local provider and services line is empty
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/144/head:pr144
git checkout pr144

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[fidencio]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

fidencio commented:
"""
Patch set updated.
"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-278325426

[sssd PR#144][-Accepted] SSSD does not start if using only the local provider and services line is empty

[fidencio]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

Label: -Accepted

[sssd PR#144][+Changes requested] SSSD does not start if using only the local provider and services line is empty

[fidencio]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

Label: +Changes requested

[sssd PR#144][-Changes requested] SSSD does not start if using only the local provider and services line is empty

[fidencio]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

Label: -Changes requested

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

pbrezina commented:
"""
Ack.
"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-278330012

[sssd PR#144][+Accepted] SSSD does not start if using only the local provider and services line is empty

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

Label: +Accepted

[sssd PR#144][-Accepted] SSSD does not start if using only the local provider and services line is empty

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

Label: -Accepted

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

lslebodn commented:
"""
We should wait for files provider and drop/rework this PR.
"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-278571942

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

jhrozek commented:
"""
I think we need to decide how we solve the local provider auto-enablement. Currently my idea (which is not in the current files provider PR, I still need to respin that one..) is that there would be a configure-time option that the distribution will use to tell if SSSD should auto-start the files provider even if not configured. I think this would be useful, because even though Fedora would enable the files provider starting with F-26 (hopefully), there are other distributions as well which might not agree. And especially with responders that don't require any domain to be set up (secrets, kcm) it is perfectly valid to run SSSD but not have SSSD manage any user accounts.

So in short, I think there is a value in this patch set. At the same time, I would appreciate to wait with pushing the patch for a day or two until I finally respin the files provider. I'd like to finish the respin today -- I'm sorry it took a bit longer than I thought, I was slowed down yesterday by cherry-picking some patches from the KCM branch to unblock pbrezina.
"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-278579343

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

jhrozek commented:
"""
I think we need to decide how we solve the local provider auto-enablement. Currently my idea (which is not in the current files provider PR, I still need to respin that one..) is that there would be a configure-time option that the distribution will use to tell if SSSD should auto-start the files provider even if not configured. I think this would be useful, because even though Fedora would enable the files provider starting with F-26 (hopefully), there are other distributions as well which might not agree. And especially with responders that don't require any domain to be set up (secrets, kcm) it is perfectly valid to run SSSD but not have SSSD manage any user accounts.

So in short, I think there is a value in this patch set. At the same time, I would appreciate to wait with pushing the patch for a day or two until I finally respin the files provider. I'd like to finish the respin today -- I'm sorry it took a bit longer than I thought, I was slowed down yesterday by cherry-picking some patches from the KCM branch to unblock pbrezina.
"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-278579343

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[simo5]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

simo5 commented:
"""
FWIW, I do not see any risk in pushing this patch as it is, and adjusting the code in the files PR if it changes anything.
"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-278590622

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

jhrozek commented:
"""
Plus, probably nothing will change in this patch.
"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-278979367

[sssd PR#144][+Accepted] SSSD does not start if using only the local provider and services line is empty

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

Label: +Accepted

[sssd PR#144][comment] SSSD does not start if using only the local provider and services line is empty

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

jhrozek commented:
"""
 master:
        00c0b7bc6969d31deab9e8e7541b4a6483b78b3e
        040ade7b2e11fecf615aedf58592cc7245900e86

"""

See the full comment at https://github.com/SSSD/sssd/pull/144#issuecomment-278980447

[sssd PR#144][closed] SSSD does not start if using only the local provider and services line is empty

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/144
Author: fidencio
 Title: #144: SSSD does not start if using only the local provider and services line is empty
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/144/head:pr144
git checkout pr144

[sssd PR#144][+Pushed] SSSD does not start if using only the local provider and services line is empty

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services line is empty

Label: +Pushed