[sssd PR#497][opened] sysdb: sanitize search filter input

[sumit-bose]

   URL: https://github.com/SSSD/sssd/pull/497
Author: sumit-bose
 Title: #497: sysdb: sanitize search filter input
Action: opened

PR body:
"""
Backport of commit 1f2662c8f97c9c0fa250055d4b6750abfc6d0835
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/497/head:pr497
git checkout pr497

[sssd PR#497][comment] sysdb: sanitize search filter input

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/497
Title: #497: sysdb: sanitize search filter input

fidencio commented:
"""
@sumit-bose, seems that this PR is exactly the same as #496. If that's the case, would
you mind closing one of them?
"""

See the full comment at https://github.com/SSSD/sssd/pull/497#issuecomment-359548113

[sssd PR#497][comment] sysdb: sanitize search filter input

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/497
Title: #497: sysdb: sanitize search filter input

sumit-bose commented:
"""
@fidencio, the number of templates in SYSDB_PWUPN_FILTER changed and because of that that
patch cannot be cherry-picked to sssd-1-13 without a change.
"""

See the full comment at https://github.com/SSSD/sssd/pull/497#issuecomment-359564404

[sssd PR#497][edited] sysdb: sanitize search filter input - backport sssd-1-14

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/497
Author: sumit-bose
 Title: #497: sysdb: sanitize search filter input - backport sssd-1-14
Action: edited

 Changed field: title
Original value:
"""
sysdb: sanitize search filter input
"""

[sssd PR#497][comment] sysdb: sanitize search filter input - backport sssd-1-14

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/497
Title: #497: sysdb: sanitize search filter input - backport sssd-1-14

fidencio commented:
"""
Both the patch and the test that is together work as expected!
"""

See the full comment at https://github.com/SSSD/sssd/pull/497#issuecomment-361226965

[sssd PR#497][comment] sysdb: sanitize search filter input - backport sssd-1-14

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/497
Title: #497: sysdb: sanitize search filter input - backport sssd-1-14

lslebodn commented:
"""
I know we started discussion as part of #496 but I firstly backported patches + sysdb unit
tests to 1.14 branch.

https://github.com/lslebodn/sssd/tree/cve_backport_1.14

Related sysdb functions are almost the same as in master branch.
I did not include afadeb1a530ff010a2f9a7552562576b843c874b into 1.14 because it is not
related to 
CVE fix. But we were backporting UPN fixes to 1.13 so we might backport that commit in
different PR

And there is also missing ba926c98b7ae605077a09ba7135e05257de62a0f because it was related
to multiple results for searches by certificate which is only in 1.15 as a feature.

@sumit-bose Could you check PR before I'll backport patches to 1.13?
"""

See the full comment at https://github.com/SSSD/sssd/pull/497#issuecomment-367340136

[sssd PR#497][comment] sysdb: sanitize search filter input - backport sssd-1-14

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/497
Title: #497: sysdb: sanitize search filter input - backport sssd-1-14

sumit-bose commented:
"""
@lslebodn, thank you for backporting. The selected patches are looking good. Can you add a
comment to the related UPN PRs about afadeb1?
"""

See the full comment at https://github.com/SSSD/sssd/pull/497#issuecomment-367363739

[sssd PR#497][comment] sysdb: sanitize search filter input - backport sssd-1-14

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/497
Title: #497: sysdb: sanitize search filter input - backport sssd-1-14

lslebodn commented:
"""
> @lslebodn, thank you for backporting. The selected patches are looking
> good.
>  
Thank you for checking. I'll push patches + create backport for 1.13

>  Can you add a comment to the related UPN PRs about afadeb1?
>  
done
"""

See the full comment at https://github.com/SSSD/sssd/pull/497#issuecomment-367377809

[sssd PR#497][comment] sysdb: sanitize search filter input - backport sssd-1-14

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/497
Title: #497: sysdb: sanitize search filter input - backport sssd-1-14

lslebodn commented:
"""
sssd-1-14:
* e45e50e4523e36f310d7ff0b052500c024c434bf
* e358dd7b4992da4c4aa7b7f769bd597222715127
* 353853d479225ba7a625658e58a3af989de909a5
* 4814454b846cbe9682e0bbcfcf9e0fe98b5181f3
* 64ef6ab9a432d6fdd231d5f96887ecabeb2fc39e
* f84055ee1c4ad60219e5d9b2ea5cc4dd6e1112eb
"""

See the full comment at https://github.com/SSSD/sssd/pull/497#issuecomment-367430480

[sssd PR#497][closed] sysdb: sanitize search filter input - backport sssd-1-14

[lslebodn]

   URL: https://github.com/SSSD/sssd/pull/497
Author: sumit-bose
 Title: #497: sysdb: sanitize search filter input - backport sssd-1-14
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/497/head:pr497
git checkout pr497

[sssd PR#497][+Pushed] sysdb: sanitize search filter input - backport sssd-1-14

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/497
Title: #497: sysdb: sanitize search filter input - backport sssd-1-14

Label: +Pushed