URL: https://github.com/SSSD/sssd/pull/635 Author: fidencio Title: #635: sss_ssh_knownhostsproxy: fix typo pubkey -> pubkeys Action: opened
PR body: """ In commit 36f2fe8f63 a discrepancy between the command line option and the manpage has been introduced.
Related: https://pagure.io/SSSD/sssd/issue/3542
Signed-off-by: Fabiano Fidêncio fidencio@redhat.com """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/635/head:pr635 git checkout pr635
URL: https://github.com/SSSD/sssd/pull/635 Title: #635: sss_ssh_knownhostsproxy: fix typo pubkey -> pubkeys
fidencio commented: """ re-test this, please """
See the full comment at https://github.com/SSSD/sssd/pull/635#issuecomment-412424422
URL: https://github.com/SSSD/sssd/pull/635 Author: fidencio Title: #635: sss_ssh_knownhostsproxy: fix typo pubkey -> pubkeys Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/635/head:pr635 git checkout pr635
URL: https://github.com/SSSD/sssd/pull/635 Title: #635: sss_ssh_knownhostsproxy: fix typo pubkey -> pubkeys
jhrozek commented: """ LGTM, let's give CI time to finish """
See the full comment at https://github.com/SSSD/sssd/pull/635#issuecomment-412428775
URL: https://github.com/SSSD/sssd/pull/635 Title: #635: sss_ssh_knownhostsproxy: fix typo pubkey -> pubkeys
fidencio commented: """ After a quick chat with @jhrozek, I've decided to re-submit the patch and treated the manual reference (pubkeys) as a typo as we should not break command line compatibility by changing the command line option. """
See the full comment at https://github.com/SSSD/sssd/pull/635#issuecomment-412428922
URL: https://github.com/SSSD/sssd/pull/635 Title: #635: sss_ssh_knownhostsproxy: fix typo pubkey -> pubkeys
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/635 Title: #635: sss_ssh_knownhostsproxy: fix typo pubkey -> pubkeys
fidencio commented: """ master: 2b3b41d """
See the full comment at https://github.com/SSSD/sssd/pull/635#issuecomment-412512696
URL: https://github.com/SSSD/sssd/pull/635 Author: fidencio Title: #635: sss_ssh_knownhostsproxy: fix typo pubkey -> pubkeys Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/635/head:pr635 git checkout pr635
sssd-devel@lists.fedorahosted.org