[sssd PR#622][opened] MC: Remove check if record is in the mapped address space

[jhrozek]

   URL: https://github.com/SSSD/sssd/pull/622
Author: jhrozek
 Title: #622: MC: Remove check if record is in the mapped address space
Action: opened

PR body:
"""
There is a check in the memory cache code that checks if a record pointer
points to the mmapped region . But since some time ago, we return not a
pointer to the mmapped region itself, but a copy to avoid issues with
invalidating an entry while the same entry is being returned.

In most cases, the check is correct, simply because of how memory is laid
out on Linux, but in some cases the check was failing and causing a high
load of SSSD.

Signed-off-by: Jakub Hrozek <jhrozek(a)redhat.com&gt;

Resolves: https://pagure.io/SSSD/sssd/issue/3776
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/622/head:pr622
git checkout pr622

[sssd PR#622][comment] MC: Remove check if record is in the mapped address space

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/622
Title: #622: MC: Remove check if record is in the mapped address space

jhrozek commented:
"""
@mzidek-rh can you review this patch, please?
"""

See the full comment at https://github.com/SSSD/sssd/pull/622#issuecomment-406637015

[sssd PR#622][comment] MC: Remove check if record is in the mapped address space

[mzidek-rh]

  URL: https://github.com/SSSD/sssd/pull/622
Title: #622: MC: Remove check if record is in the mapped address space

mzidek-rh commented:
"""
Thanks @jhrozek for the explanation, It makes sense to me now. I will just run a CI check
and if it passes then I will give my ACK.
"""

See the full comment at https://github.com/SSSD/sssd/pull/622#issuecomment-408413993

[sssd PR#622][comment] MC: Remove check if record is in the mapped address space

[mzidek-rh]

  URL: https://github.com/SSSD/sssd/pull/622
Title: #622: MC: Remove check if record is in the mapped address space

mzidek-rh commented:
"""
ACK.
"""

See the full comment at https://github.com/SSSD/sssd/pull/622#issuecomment-408442516

[sssd PR#622][+Accepted] MC: Remove check if record is in the mapped address space

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/622
Title: #622: MC: Remove check if record is in the mapped address space

Label: +Accepted

[sssd PR#622][+Pushed] MC: Remove check if record is in the mapped address space

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/622
Title: #622: MC: Remove check if record is in the mapped address space

Label: +Pushed

[sssd PR#622][closed] MC: Remove check if record is in the mapped address space

[jhrozek]

   URL: https://github.com/SSSD/sssd/pull/622
Author: jhrozek
 Title: #622: MC: Remove check if record is in the mapped address space
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/622/head:pr622
git checkout pr622