[PATCH] AD: properly intitialize GC from ad_server option

[Sumit Bose]

Hi,

this patch fixes a copy-n-paste error in the init code of the AD
provider.

bye,
Sumit

[steve]

On Wed, 2013-10-02 at 18:27 +0200, Sumit Bose wrote:
>  Hi,
>  
>  this patch fixes a copy-n-paste error in the init code of the AD
>  provider. 
Hi
Does this patch fix:
https://lists.fedorahosted.org/pipermail/sssd-devel/2013-October/016904.html
?

Thanks,
Steve

[Sumit Bose]

On Wed, Oct 02, 2013 at 06:31:14PM +0200, steve wrote:
>  On Wed, 2013-10-02 at 18:27 +0200, Sumit Bose wrote:
>  > Hi,
>  > 
>  > this patch fixes a copy-n-paste error in the init code of the AD
>  > provider.
>  
>  Hi
>  Does this patch fix:
>  https://lists.fedorahosted.org/pipermail/sssd-devel/2013-October/016904.html
>  ? 
yes, see mail in that thread :-)

bye,
Sumit

>  
>  Thanks,
>  Steve
>  
>  
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[Jakub Hrozek]

On Wed, Oct 02, 2013 at 06:27:58PM +0200, Sumit Bose wrote:
>  Hi,
>  
>  this patch fixes a copy-n-paste error in the init code of the AD
>  provider.
>  
>  bye,
>  Sumit 
>  From 1211ee75a25db259fe5a680f702e5acb0f597c91 Mon Sep 17 00:00:00
> 2001
>  From: Sumit Bose <sbose(a)redhat.com&gt;
>  Date: Wed, 2 Oct 2013 18:21:42 +0200
>  Subject: [PATCH] AD: properly intitialize GC from ad_server option
>  
>  ---
>   src/providers/ad/ad_common.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>  
>  diff --git a/src/providers/ad/ad_common.c b/src/providers/ad/ad_common.c
>  index 700ac03..ab62d64 100644
>  --- a/src/providers/ad/ad_common.c
>  +++ b/src/providers/ad/ad_common.c
>  @@ -441,7 +441,7 @@ _ad_servers_init(TALLOC_CTX *mem_ctx,
>           }
>           sdata->gc = true;
>   
>  -        ret = be_fo_add_server(bectx, fo_service, list[i], 0, sdata, primary);
>  +        ret = be_fo_add_server(bectx, fo_gc_service, list[i], 0, sdata, primary);
>           if (ret && ret != EEXIST) {
>               DEBUG(SSSDBG_FATAL_FAILURE, ("Failed to add server\n"));
>               goto done;
>  -- 
>  1.7.7.6
>   
ACK.

Very nice catch, I think we mostly tested with service discovery..

[Jakub Hrozek]

On Thu, Oct 03, 2013 at 08:23:45PM +0200, Jakub Hrozek wrote:
>  On Wed, Oct 02, 2013 at 06:27:58PM +0200, Sumit Bose wrote:
>  > Hi,
>  > 
>  > this patch fixes a copy-n-paste error in the init code of the AD
>  > provider.
>  > 
>  > bye,
>  > Sumit
>  
>  > From 1211ee75a25db259fe5a680f702e5acb0f597c91 Mon Sep 17 00:00:00 2001
>  > From: Sumit Bose <sbose(a)redhat.com&gt;
>  > Date: Wed, 2 Oct 2013 18:21:42 +0200
>  > Subject: [PATCH] AD: properly intitialize GC from ad_server option
>  > 
>  > ---
>  >  src/providers/ad/ad_common.c |    2 +-
>  >  1 files changed, 1 insertions(+), 1 deletions(-)
>  > 
>  > diff --git a/src/providers/ad/ad_common.c b/src/providers/ad/ad_common.c
>  > index 700ac03..ab62d64 100644
>  > --- a/src/providers/ad/ad_common.c
>  > +++ b/src/providers/ad/ad_common.c
>  > @@ -441,7 +441,7 @@ _ad_servers_init(TALLOC_CTX *mem_ctx,
>  >          }
>  >          sdata->gc = true;
>  >  
>  > -        ret = be_fo_add_server(bectx, fo_service, list[i], 0, sdata, primary);
>  > +        ret = be_fo_add_server(bectx, fo_gc_service, list[i], 0, sdata, primary);
>  >          if (ret && ret != EEXIST) {
>  >              DEBUG(SSSDBG_FATAL_FAILURE, ("Failed to add server\n"));
>  >              goto done;
>  > -- 
>  > 1.7.7.6
>  > 
>  
>  ACK.
>  
>  Very nice catch, I think we mostly tested with service discovery.. 
Pushed to master and sssd-1-11