ehlo,
The dbus_req and associated talloc context are no longer valid after execution of the function sbus_request_return_and_finish even if error code was returned.
Simple patch is attached.
LS
On (29/01/15 10:58), Pavel Březina wrote:
On 01/29/2015 08:59 AM, Lukas Slebodnik wrote:
ehlo,
The dbus_req and associated talloc context are no longer valid after execution of the function sbus_request_return_and_finish even if error code was returned.
Simple patch is attached.
LS
Ack.
Thank you for review.
Could you attach link to CI results? I prefer reviewer attach links.
LS
On Thu, Jan 29, 2015 at 11:51:30AM +0100, Lukas Slebodnik wrote:
On (29/01/15 10:58), Pavel Březina wrote:
On 01/29/2015 08:59 AM, Lukas Slebodnik wrote:
ehlo,
The dbus_req and associated talloc context are no longer valid after execution of the function sbus_request_return_and_finish even if error code was returned.
Simple patch is attached.
LS
Ack.
Thank you for review.
Could you attach link to CI results?
Here you go: http://sssd-ci.duckdns.org/logs/commit/33/889b2ad764beb6b129f5211b1fab9790da...
I prefer reviewer attach links.
Me too, but in the absence of a link by reviewer, I run CI before pushing. It would be awesome if there was a tool that could scrape the patches from somewhere (ML? Patchwork? Should we ditch the list altogether?) and run CI automatically. Something like Travis CI does for github pull requests.
On Thu, Jan 29, 2015 at 06:32:27PM +0100, Jakub Hrozek wrote:
On Thu, Jan 29, 2015 at 11:51:30AM +0100, Lukas Slebodnik wrote:
On (29/01/15 10:58), Pavel Březina wrote:
On 01/29/2015 08:59 AM, Lukas Slebodnik wrote:
ehlo,
The dbus_req and associated talloc context are no longer valid after execution of the function sbus_request_return_and_finish even if error code was returned.
Simple patch is attached.
LS
Ack.
Thank you for review.
Could you attach link to CI results?
Here you go: http://sssd-ci.duckdns.org/logs/commit/33/889b2ad764beb6b129f5211b1fab9790da...
I prefer reviewer attach links.
Me too, but in the absence of a link by reviewer, I run CI before pushing. It would be awesome if there was a tool that could scrape the patches from somewhere (ML? Patchwork? Should we ditch the list altogether?) and run CI automatically. Something like Travis CI does for github pull requests.
master: 33889b2ad764beb6b129f5211b1fab9790da8884 sssd-1-12: 31dd2a8c5042493b24ef4f9360139525c018bcb4 sssd-1-11: 697d13aea5f6b020813111f1a50511cfc440f91c
sssd-devel@lists.fedorahosted.org