URL: https://github.com/SSSD/sssd/pull/279 Author: lslebodn Title: #279: BUILD: Fix build without ssh Action: opened
PR body: """ Reported by gentoo user on IRC because SSH responder is optionally build there.
cache_req_host_by_name_lookup should be used only by ssh responder. But we cannot rely on this fact and therefore we should return ERR_INTERNAL instead of EOK to catch mis-usage of the cache_req plugin
autoreconf -if ./configure --without-ssh make check
CCLD sssd_nss src/responder/common/cache_req/plugins/cache_req_host_by_name.o: In function `cache_req_host_by_name_lookup': src/responder/common/cache_req/plugins/cache_req_host_by_name.c:48: undefined reference to `sysdb_get_ssh_host' collect2: error: ld returned 1 exit status make: *** [Makefile:14285: sssd_nss] Error 1
src/tests/cmocka/test_utils-test_sss_ssh.o: In function `test_textual_public_key': src/tests/cmocka/test_sss_ssh.c:78: undefined reference to `sss_ssh_format_pubkey' src/tests/cmocka/test_sss_ssh.c:82: undefined reference to `sss_ssh_format_pubkey' src/tests/cmocka/test_sss_ssh.c:86: undefined reference to `sss_ssh_format_pubkey' src/tests/cmocka/test_sss_ssh.c:89: undefined reference to `sss_ssh_format_pubkey' src/tests/cmocka/test_sss_ssh.c:92: undefined reference to `sss_ssh_format_pubkey' src/tests/cmocka/test_utils-test_sss_ssh.o:src/tests/cmocka/test_sss_ssh.c:95: more undefined references to `sss_ssh_format_pubkey' follow collect2: error: ld returned 1 exit status """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/279/head:pr279 git checkout pr279
URL: https://github.com/SSSD/sssd/pull/279 Title: #279: BUILD: Fix build without ssh
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/279 Title: #279: BUILD: Fix build without ssh
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/279 Title: #279: BUILD: Fix build without ssh
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/279 Title: #279: BUILD: Fix build without ssh
lslebodn commented: """ master: * d82ffa52dd4c3bb11115b1687edc189284797329
sssd-1-14: * f46d1474b7b249eda690e78b02adea981fbb058c
sssd-1-13: * 6b883efd16eb35a1a3790c1af07f87b21a17cfe8 """
See the full comment at https://github.com/SSSD/sssd/pull/279#issuecomment-303995837
URL: https://github.com/SSSD/sssd/pull/279 Author: lslebodn Title: #279: BUILD: Fix build without ssh Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/279/head:pr279 git checkout pr279
URL: https://github.com/SSSD/sssd/pull/279 Title: #279: BUILD: Fix build without ssh
Label: +Pushed
sssd-devel@lists.fedorahosted.org