[PATCH] GPO: use SDAP_SASL_AUTHID as samAccountName

[Sumit Bose]

Hi,

this patch contains a fix for https://fedorahosted.org/sssd/ticket/2692.
If uses the SDAP_SASL_AUTHID config option because it already contains
the right NetBIOS name in the AD case.

I basically tested the patch on a host with a long hostname. Without the
patch I see:

[ad_gpo_connect_done] (0x0400): sam_account_name is LONG-HOSTNAME-GPO-TEST$

with the patch it is changed to

[ad_gpo_connect_done] (0x0400): sam_account_name is LONG-HOSTNAME-G$

and gpo's are found and downloaded. It would be nice is someone can do a
regression test on a host with a shorter name as well.

With this patch the only remaining caller for sss_krb5_get_primary() is
in the same source file. Shall it be made static and removed from
sss_krb5.h?

bye,
Sumit

[Jakub Hrozek]

On Tue, Sep 01, 2015 at 02:57:36PM +0200, Sumit Bose wrote:
> With this patch the only remaining caller for sss_krb5_get_primary() is
> in the same source file. Shall it be made static and removed from
> sss_krb5.h?

Yes, but in a different patch, please.

[Sumit Bose]

On Tue, Sep 01, 2015 at 03:14:59PM +0200, Jakub Hrozek wrote:
> On Tue, Sep 01, 2015 at 02:57:36PM +0200, Sumit Bose wrote:
> > With this patch the only remaining caller for sss_krb5_get_primary() is
> > in the same source file. Shall it be made static and removed from
> > sss_krb5.h?
>
> Yes, but in a different patch, please.

here you are, new version attached.

bye,
Sumit
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[Jakub Hrozek]

On Tue, Sep 01, 2015 at 06:01:59PM +0200, Sumit Bose wrote:
> On Tue, Sep 01, 2015 at 03:14:59PM +0200, Jakub Hrozek wrote:
> > On Tue, Sep 01, 2015 at 02:57:36PM +0200, Sumit Bose wrote:
> > > With this patch the only remaining caller for sss_krb5_get_primary() is
> > > in the same source file. Shall it be made static and removed from
> > > sss_krb5.h?
> >
> > Yes, but in a different patch, please.
>
> here you are, new version attached.
>
> bye,
> Sumit

Sorry about the delay in review. These patches look good to me, ACK.

CI: http://sssd-ci.duckdns.org/logs/job/26/60/summary.html

(the rawhide failure is not related, the VM is having some issues at the
moment)

[Jakub Hrozek]

On Mon, Sep 14, 2015 at 03:40:05PM +0200, Jakub Hrozek wrote:
> On Tue, Sep 01, 2015 at 06:01:59PM +0200, Sumit Bose wrote:
> > On Tue, Sep 01, 2015 at 03:14:59PM +0200, Jakub Hrozek wrote:
> > > On Tue, Sep 01, 2015 at 02:57:36PM +0200, Sumit Bose wrote:
> > > > With this patch the only remaining caller for sss_krb5_get_primary() is
> > > > in the same source file. Shall it be made static and removed from
> > > > sss_krb5.h?
> > >
> > > Yes, but in a different patch, please.
> >
> > here you are, new version attached.
> >
> > bye,
> > Sumit
>
> Sorry about the delay in review. These patches look good to me, ACK.
>
> CI: http://sssd-ci.duckdns.org/logs/job/26/60/summary.html
>
> (the rawhide failure is not related, the VM is having some issues at the
> moment)

* master:
        * 560b624b34895df55bf489a1d53380c6c8c82e03 
        * 9a847b5d7dfea403d838274950402cccc36659d0